service set/unset silently erases the stored config when service.json cannot be decoded #52412

Activity

1. github-actions

   assigned

   nexxeln

   on Oct 1, 2026
2. github-actions commented on Oct 1, 2026

   

   github-actionsBot

   on Oct 1, 2026 – with GitHub Actions

   Contributor

   More actions

   ---

   This issue might be a duplicate of an existing issue. Please check:

   • #46128: reports silent data loss from unlocked whole-file JSON read-modify-write operations during concurrent writes, affecting auth.json rather than service.json.
3. opencodejr commented on Oct 28, 2026

   

   opencodejrBot

   on Oct 28, 2026

   Contributor

   More actions

   Thanks for the detailed report. I can reproduce this.

   Commit 5556ad563 isn't in a release, so I tested the latest release, @opencode/[email protected], using throwaway XDG directories:

   1. Wrote a truncated service.json containing hostname, port, password and env.
   2. opencode service get printed {}.
   3. opencode service set env NEW_VAR v exited 0 with no warning.
   4. The file now contained only {"env":{"NEW_VAR":"v"}}. Everything else was gone.

   It still happens on the latest dev (f0160a1) run from source. There, ServiceConfig.read still returns {} when the file can be read but neither the current nor the legacy format decodes it, and the write paths then overwrite the file. On dev, the temp file name is now per-process, which covers the fixed service.json.tmp collision you described. I did not test the concurrency part.

   The script below reproduces it.

   Reproduction script (repro.sh)

   #!/usr/bin/env bash
   # Reproduces anomalyco/opencode#52412: an undecodable service.json is silently replaced.
   # Usage: ./repro.sh            (uses `opencode` from PATH)
   #        OC_DEV=/path/to/checkout ./repro.sh   (runs CLI from source)
   set -u
   WORK=$(mktemp -d)
   export XDG_CONFIG_HOME=$WORK/config XDG_STATE_HOME=$WORK/state XDG_DATA_HOME=$WORK/data XDG_CACHE_HOME=$WORK/cache
   mkdir -p "$XDG_CONFIG_HOME/opencode"
   oc() {
     if [ -n "${OC_DEV:-}" ]; then
       bun --conditions=browser --preload="$OC_DEV/packages/tui/node_modules/@opentui/solid/scripts/preload.js" "$OC_DEV/packages/cli/src/index.ts" "$@"
     else opencode "$@"; fi
   }
   echo "version: $(oc --version)"
   # Builds run from source use the "local" channel, whose file is service-local.json
   if [ -n "${OC_DEV:-}" ]; then CFG=$XDG_CONFIG_HOME/opencode/service-local.json; else CFG=$XDG_CONFIG_HOME/opencode/service.json; fi
   # A file truncated mid-write (fails JSON decoding)
   printf '{"hostname":"127.0.0.1","port":4321,"password":"user-secret","env":{"API_KEY":"sk-live-1' > "$CFG"
   echo "--- before:"; cat "$CFG"; echo
   echo "--- opencode service get:"; oc service get
   echo "--- opencode service set env NEW_VAR v:"; oc service set env NEW_VAR v; echo "exit=$?"
   echo "--- after:"; cat "$CFG"

   Run it: bash repro.sh
4. opencodejr

   added

   reproduced

   severity:high

   on Oct 28, 2026