Skip to content

[FEATURE]: Land TUI i18n groundwork adapted from #48731 #51998

Closed as not planned

Description

@imyu37

Feature hasn't been suggested before.

  • I have verified this feature I'm about to request hasn't been suggested before.

Describe the enhancement you want to request

The TUI (packages/tui) currently ships zero i18n: roughly 700–1000 user-facing strings are hardcoded English, while the app/desktop side already has per-locale dictionaries.

#48731 by @neriousy laid down the full groundwork (lazy per-locale dictionaries, t()/plural()/number() helpers, language picker, config.language) and the architecture looked solid in review, but the PR has been stalled — no updates since 2026-09-23 and no response to the collaboration comment on the PR.

Rather than let that work rot, I would like to carry it forward:

  1. Merge Feat/tui i18n #48731 onto the current v2 branch (it had fallen ~550 commits behind).
  2. Resolve conflicts with v2's evolved TUI code (theme tokens, dialog APIs, diff-viewer sources, fail/attempt helpers) while keeping the PR's language.t(...) wiring.
  3. Drop parts of the PR that reference APIs v2 has since removed.
  4. Run lint/typecheck/tests with a baseline comparison to prove zero new failures.

All of @neriousy's original commits are preserved via a merge commit, so authorship stays intact.

Related: #48731

Follow-up PR: #52000.

Activity

  1. github-actions commented on Sep 29, 2026

    @github-actions
    Contributor

    This issue doesn't fully meet our contributing guidelines.

    What needs to be fixed:

    • The feature request is missing the required verification checkbox. Please add and complete the checkbox from the Feature Request template.

    Please edit this issue to address the above within 2 hours, or it will be automatically closed.


    This issue might be a duplicate of existing issues. Please check:

    If you believe this was flagged incorrectly, please let a maintainer know.

  2. github-actions commented on Sep 29, 2026

    @github-actions
    Contributor

    This issue has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

    Feel free to open a new issue that follows our issue templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions