Session recovery loses client environment and inherits another agent identity #51784

Activity

1. github-actions

   assigned

   rekram1-node

   on Sep 28, 2026
2. github-actions commented on Sep 28, 2026

   

   github-actionsBot

   on Sep 28, 2026 – with GitHub Actions

   Contributor

   More actions

   This issue might be a duplicate of existing issues. Please check:

   • #38897: service: make subprocess PATH deterministic across reconnect election — shell commands can inherit a different client/service process environment after service replacement.
   • #44914: opencode v2: background service does not inherit workspace .envrc variables from the TUI — workspace environment from the client is unavailable to subprocesses started by the background service.
3. gszep commented on Sep 28, 2026

   

   gszep

   on Sep 28, 2026

   Author

   More actions

   Related to #38897, but this reproduction starts after explicit per-session environment binding already exists: recovery runs before that in-memory binding is restored. #51786 retains only the requirement and waits for reattachment. #44914 concerns MCP configuration interpolation; this patch is limited to local session shells and recovery.
4. opencodejr commented on Oct 28, 2026

   

   opencodejrBot

   on Oct 28, 2026

   Contributor

   More actions

   Thanks for the detailed report. I was able to reproduce this.

   Setup: the server ran with AGENT_ID=A in its own environment. A session was bound to AGENT_ID=B with session.environment.

   1. The session's first shell command logged AGENT_ID=B.
   2. I stopped the server while that command was still running and started a new one. The client did not reattach its environment.
   3. Recovery resumed the turn, and the next shell command logged AGENT_ID=A, the server's own environment instead of the session's.

   This happens on 2.0.15 and still happens on the latest dev (86ce19d). The script below reproduces it with a simulated model. I stopped the server normally rather than crashing it, which recovery handles the same way.

   As you pointed out, the per-session environment is only kept in memory, and shells fall back to the server's own environment when it's missing (packages/core/src/shell.ts). #51215 only skips claims held by a process that is still alive, so it doesn't cover this case. I've passed it on to the maintainers.

   Reproduction script (drive.ts)

   // Repro for #51784: after a server restart, a recovered session's shells use the
   // new server process environment instead of the environment bound via session.environment.
   // Run with: AGENT_ID=A OPENCODE_DRIVE_DB=restart.sqlite opencode-drive start --name r51784 --script drive.ts  (add --dev <checkout> for source)
   import { Effect } from "effect"
   import { readFileSync, existsSync, rmSync } from "node:fs"
   import { defineScript, Llm } from "opencode-drive"
   
   const LOG = "/tmp/opencode/agent-51784.log"
   const read = () => (existsSync(LOG) ? readFileSync(LOG, "utf8") : "")
   const waitFor = (needle: string, ms: number) =>
     Effect.gen(function* () {
       const end = Date.now() + ms
       while (Date.now() < end) {
         if (read().includes(needle)) return true
         yield* Effect.sleep(250)
       }
       return false
     })
   
   export default defineScript({
     launch: "manual",
   
     run: ({ server, llm }) =>
       Effect.gen(function* () {
         rmSync(LOG, { force: true })
         console.log("server process AGENT_ID =", process.env.AGENT_ID)
         const oc = yield* server.launch()
         const session = yield* oc.session.create({ title: "agent B session" })
         // Client binds its own environment (agent B) to the session.
         yield* oc.session.environment({
           sessionID: session.id,
           variables: { PATH: process.env.PATH ?? "/usr/bin:/bin", HOME: process.env.HOME ?? "/root", AGENT_ID: "B" },
         })
         yield* llm.queue(
           Llm.toolCall({ index: 0, id: "call_1", name: "shell",
             input: { command: `echo "before-restart AGENT_ID=$AGENT_ID" >> ${LOG}; sleep 120`, description: "long" } }),
           Llm.finish("tool-calls"),
         )
         yield* oc.session.prompt({ sessionID: session.id, text: "run the long command" })
         if (!(yield* waitFor("before-restart", 20000))) throw new Error("first shell never ran")
         console.log("LOG before restart:\n" + read())
   
         // Server dies while the execution is active; successor starts (with AGENT_ID=A in its env).
         yield* server.kill()
         yield* llm.queue(
           Llm.toolCall({ index: 0, id: "call_2", name: "shell",
             input: { command: `echo "after-recovery AGENT_ID=$AGENT_ID" >> ${LOG}`, description: "check" } }),
           Llm.finish("tool-calls"),
         )
         yield* llm.queue(Llm.text("done"))
         yield* server.launch()
         // Client has NOT reattached its environment.
         const ok = yield* waitFor("after-recovery", 30000)
         console.log("LOG after recovery:\n" + read())
         if (!ok) throw new Error("recovered shell did not run")
       }),
   })

   Run it with opencode-drive: opencode-drive run ./drive.ts. It drives opencode from your PATH.
5. opencodejr

   added

   reproduced

   on Oct 28, 2026