ACP usage_update mislabels non-USD costs as USD #38667

Activity

1. github-actions

   assigned

   kitlangton

   on Jul 24, 2026
2. kagura-chen commented on Jul 24, 2026

   

   kagura-chen

   on Jul 24, 2026

   Contributor

   More actions

   I'd like to work on this. The root cause is clear: both usage.ts (L212) and service.ts (L653) hardcode currency: "USD" in the ACP usage_update. The ProviderCost schema has no currency field, so there's no way for custom providers to specify their pricing currency.

   Proposed fix:

   1. Add optional currency field to ProviderCost in provider.ts (defaults to "USD" for backward compat)
   2. Add findCostCurrency() utility to usage.ts (mirrors existing findContextLimit())
   3. Thread the currency through sendUpdate in both usage.ts and service.ts
   4. Add test coverage for custom currency propagation

   🚀React with 🚀1Reacted by Dinah Xiaoman G
3. DinahK-2SO commented on Jul 27, 2026

   

   DinahK-2SO

   on Jul 27, 2026

   Author

   More actions

   I'd like to work on this. The root cause is clear: both usage.ts (L212) and service.ts (L653) hardcode currency: "USD" in the ACP usage_update. The ProviderCost schema has no currency field, so there's no way for custom providers to specify their pricing currency.

   Proposed fix:

   1. Add optional currency field to ProviderCost in provider.ts (defaults to "USD" for backward compat)
   2. Add findCostCurrency() utility to usage.ts (mirrors existing findContextLimit())
   3. Thread the currency through sendUpdate in both usage.ts and service.ts
   4. Add test coverage for custom currency propagation

   @kagura-agent Why not
4. kagura-chen commented on Jul 27, 2026

   

   kagura-chen

   on Jul 27, 2026

   Contributor

   More actions

   Thanks @DinahK-2SO — I'll get a PR up for this. Will follow the approach outlined above (optional currency field with USD default for backward compat).

   🚀React with 🚀1Reacted by Dinah Xiaoman G
5. github-actions commented on Sep 27, 2026

   

   github-actionsBot

   on Sep 27, 2026 – with GitHub Actions

   Contributor

   More actions

   To stay organized issues are automatically closed after 60 days of no activity. If the issue is still relevant please open a new one.
6. github-actions

   closed this as not plannedon Sep 27, 2026
7. Meinianda-L

   added a commit that references this issue on Sep 27, 2026

   fix(acp): respect provider currency in usage_update instead of hardco…

   ...

   This issue will close once commit b41c0c9 is merged into the 'dev' branch.

   b41c0c9