v2 tui: model favorites are inconsistent across sessions #37053

Summary

Model favorites are not consistently persisted or synchronized across concurrent OpenCode v2 sessions. The same model selector shows different Favorites lists in two sessions.

Environment

• opencode version: opencode2 v0.0.0-next-15402
• OS: Linux 7.0.10-arch1-1 x86_64 (Arch/Omarchy)
• Terminal: TERM=xterm-256color, COLORTERM=truecolor; terminal application unavailable
• Shell: /usr/bin/bash
• Install/channel: next, executable at /usr/bin/opencode2
• Active plugins: .opencode/plugins/graphify.js

Reproduction

1. Open two OpenCode v2 TUI sessions.
2. In one session, open the model selector and favorite a model with Ctrl+F.
3. Open the model selector in both sessions.
4. Compare the Favorites lists.

Expected Behavior

A favorited model should be persisted and shown as a favorite in every OpenCode session.

Actual Behavior

The Favorites lists differ between sessions:

• Session 1 shows GPT-5.6 Luna and GPT-5.5 under Favorites.
• Session 2 shows only GPT-5.5 under Favorites.
• In session 2, GPT-5.6 Luna appears under Recent instead of Favorites.

This suggests favorite state is process-local, stale, or overwritten rather than consistently synchronized through persisted state.

Additional Context

Observed with concurrent OpenCode v2 sessions.

This may be a v2 regression or a related variant of #8375, which addressed favorites being wiped on startup due to a persistence race.

Two screenshots were supplied showing the inconsistent model selector state. The GitHub CLI cannot directly upload image binaries embedded in this chat, so the exact visible evidence is described above.