V2 regression: Enter during CJK IME composition submits in review panel #35746

Activity

1. github-actions

   assigned

   Brendonovich

   on Jul 7, 2026
2. powoct commented on Jul 24, 2026

   

   powoct

   on Jul 24, 2026

   More actions

   I hit the same thing in Safari with the web app prompt input (packages/app/src/components/prompt-input.tsx), and the existing isImeComposing guard can't catch it there because of Safari's event order:

   Chrome:  keydown(Enter, isComposing=true, keyCode=229) -> compositionend   guard works
   Safari:  compositionend -> keydown(Enter, isComposing=false, keyCode=13)   all three conditions fail
   

   Safari fires compositionend before the confirming Enter keydown, so checking event.isComposing / keyCode === 229 alone isn't enough there — the guard also needs a short time window after compositionend (comparing event.timeStamp, which shares the same time origin as keydown).

   Safari has a second related problem where the composition itself gets aborted mid-input; I filed that separately as #38674.

   I'd like to work on this. Plan: add the timeStamp-based guard to the app prompt input, and for the v2 input feed the same logic into the composing flag in interaction.ts so machine.ts stays a pure state machine.

   Environment: macOS Safari, Japanese IME and Chinese pinyin.
3. github-actions commented on Sep 24, 2026

   

   github-actionsBot

   on Sep 24, 2026 – with GitHub Actions

   Contributor

   More actions

   To stay organized issues are automatically closed after 60 days of no activity. If the issue is still relevant please open a new one.
4. github-actions

   closed this as not plannedon Sep 24, 2026