Repository navigation
duration() shows wrong days and hours past 24h #32956
Description
Description
duration() in packages/tui/src/util/locale.ts gets the days/hours branch wrong once a duration reaches 24h.
It computes days from the sub-hour remainder (input % 3600000) divided by a full day, which is always 0, and leaves hours as the uncapped total:
const hours = Math.floor(input / 3600000) // total hours, never capped
const days = Math.floor((input % 3600000) / 86400000) // always 0So:
- 1 day →
0d 24h(expected1d 0h) - 2d 3h →
0d 51h(expected2d 3h)
It's used to show elapsed time in the TUI session view, where a span is completed - created over a whole session or subagent, so anything that ran 24h or longer shows a nonsensical value.
OpenCode version
dev (1.17.8)
Steps to reproduce
duration(86400000) // "0d 24h", expected "1d 0h"
duration(183600000) // "0d 51h", expected "2d 3h"Metadata
Metadata
Assignees
Labels
No labels
Activity
fix(tui): correct duration() days/hours calculation past 24h
tui: fix multi-day duration formatting (anomalyco#33651)
sync: merge upstream/dev catch-up (629 commits) (#31)
tui: fix multi-day duration formatting (anomalyco#33651)
fix(test): resolve shell/cwd unit-test failures surfaced by GitHub-ho…
tui: fix multi-day duration formatting (#33651)
tui: fix multi-day duration formatting (anomalyco#33651)