[BUG] V1 tool errors silently swallowed by Effect.orDie - AI never sees error messages #31772

Description

V1 tools (edit, write, apply_patch, shell, glob, grep, etc.) that throw errors during execution have those errors silently swallowed. The root cause is Effect.orDie in packages/opencode/src/tool/tool.ts:146 which converts all errors to defects. Defects bypass the normal error reporting path and are invisible to the AI model.

Impact

The AI never sees error messages from V1 tools. Instead of receiving a clear error like "File not found" or "Permission denied", the tool silently returns nothing or the session appears to hang. This causes the AI to retry failed operations without understanding why they failed.

Root Cause

// tool.ts:146 - V1 tool wrapper
}).pipe(Effect.orDie, Effect.withSpan(...))

Effect.orDie converts ALL errors to defects (unrecoverable crashes). The core registry (packages/core/src/tool/registry.ts:68) only catches LLM.ToolFailure errors, not defects. So V1 tool runtime errors propagate as defects and never reach the model as meaningful error messages.

Affected Tools

All V1 tools defined via Tool.define() in packages/opencode/src/tool/:

• edit.ts (throws on file not found, oldString mismatch)
• write.ts (throws on write failures)
• shell.ts (throws on spawn failures)
• apply_patch.ts (throws on patch failures)
• task.ts (throws on timeout/subagent failures)
• glob.ts, grep.ts (throws on search failures)

OpenCode version

1.17.3