Plugins with github: specifier fail to load on restart (cache hit path resolves wrong package name) #24437

Description

Plugins installed via github: specifier (e.g. github:Edison-A-N/opencode-agent-memory) load successfully on first launch but fail with ENOENT on every subsequent restart, until the cache directory is manually deleted.

Error from logs:

ERROR service=plugin path=github:Edison-A-N/opencode-agent-memory
  error=ENOENT: no such file or directory, open
  '~/.cache/opencode/packages/github:Edison-A-N/opencode-agent-memory/node_modules/github:Edison-A-N/package.json'
  failed to resolve plugin server entry

The expected path should be node_modules/@Edison-A-N/opencode-agent-memory/package.json, but the cache-hit code path uses the raw specifier string as the package name.

Root cause is in packages/core/src/npm.ts — the Npm.add() function:

• First install (cache dir absent): reify() runs, then tree.edgesOut provides the correct installed path → ✅ works
• Cache hit (cache dir exists): npa(pkg).name is used to reconstruct the path, but npa("github:user/repo") returns name: null, so it falls back to the raw spec string "github:Edison-A-N/opencode-agent-memory" → ❌ ENOENT

// packages/core/src/npm.ts — Npm.add()
const name = (() => {
  try {
    return npa(pkg).name ?? pkg  // npa("github:user/repo").name → null → falls back to raw spec
  } catch {
    return pkg
  }
})()

if (yield* afs.existsSafe(dir)) {
  // Cache hit: constructs node_modules/github:Edison-A-N/opencode-agent-memory → wrong
  return resolveEntryPoint(name, path.join(dir, "node_modules", name))
}

A possible fix: when the cache directory exists, read the dependency name from the cached package.json (written during reify) instead of relying on npa().name:

if (yield* afs.existsSafe(dir)) {
  const manifest = yield* afs.readJson(path.join(dir, "package.json")).pipe(Effect.option)
  if (Option.isSome(manifest)) {
    const deps = (manifest.value as any)?.dependencies ?? {}
    const depName = Object.keys(deps)[0]
    if (depName) {
      return resolveEntryPoint(depName, path.join(dir, "node_modules", depName))
    }
  }
  return resolveEntryPoint(name, path.join(dir, "node_modules", name))
}

Plugins

github:Edison-A-N/opencode-agent-memory

OpenCode version

1.3.13

Steps to reproduce

1. Add plugin to config: "plugin": ["github:Edison-A-N/opencode-agent-memory"]
2. Start opencode → plugin loads (first install via reify)
3. Restart opencode → plugin fails with ENOENT
4. Workaround: rm -rf ~/.cache/opencode/packages/github:Edison-A-N/opencode-agent-memory/ → works again until next restart

Screenshot and/or share link

No response

Operating System

Linux (Ubuntu)

Terminal

Ghostty