Repository navigation
[BUG] ~30 catch blocks silently swallow errors across core modules #24327
Description
Description
Found ~30 instances of catch {} or catch { } in production code that suppress errors completely without any logging.
Most critical locations:
auth/index.ts:62— JSON.parse ofOPENCODE_AUTH_CONTENTfails silently, causing auth to be silently absentsession/message-v2.ts:1191— stream error JSON parse fails silentlysession/session.ts:508— sessionremove()catches error but lets it succeed anywaylsp/client.ts:150— server stderr at debug level (startup errors invisible by default)pty/index.ts:125— process kill/close failures could create zombie processesmcp/index.ts:524— SIGTERM failures not reportedglobal/index.ts:54— cache directory cleanup failure not loggedprovider/error.ts:71— JSON parse errors in response handling not loggedutil/filesystem.ts— statSync, realpathSync, glob scan failures not loggedutil/error.ts:11— JSON.stringify failure not logged
Also session/llm.ts:258 uses catch (e: any) instead of catch (e: unknown).
Reproduction steps
- Search for
catch {}orcatch { }inpackages/opencode/src/ - Observe that no logging occurs within these blocks
- Errors that cause failures in these paths are silently lost
Environment info
- OS: all platforms
- Bun version: 1.3.x
- OpenCode version: current dev branch
Metadata
Metadata
Assignees
Labels
No labels
Activity
github-actions commentedon Apr 25, 2026
This issue doesn't fully meet our contributing guidelines.
What needs to be fixed:
[FEATURE]:), or Question. The current title uses afix:prefix which is a PR convention, not an issue template format.Please edit this issue to address the above within 2 hours, or it will be automatically closed.
This issue might be a duplicate of existing issues. Please check:
global/index.tsand config catch blocks)mcp/index.ts,pty/index.tscatch blocks)If you believe this was flagged incorrectly, please let a maintainer know.
[-]fix: ~30 catch blocks silently swallow errors across core modules[/-][+][BUG] ~30 catch blocks silently swallow errors across core modules[/+]github-actions commentedon Apr 25, 2026
Thanks for updating the issue! It now follows the contributing guidelines with a clear description, specific code locations, reproduction steps, and environment info. The needs:compliance label has been removed.
alfredocristofano commentedon Apr 26, 2026
Update: after inspecting the current dev branch, most of the silent catch blocks listed in this issue have already been fixed in prior commits:
The only remaining truly empty catch {} in the entire packages/opencode/src tree was in cli/cmd/tui/component/dialog-workspace-create.tsx:146. I've opened PR #24502 to fix that one.
Given that the core issues are already resolved, this issue could be closed or kept open until #24502 is merged.
alfredocristofano commentedon Apr 27, 2026
Re-checking current
dev, this is still open work. There are still emptycatch {}blocks and a couple ofcatch (e: any)sites inpackages/opencode/src.The linked PRs have not landed yet, and a few of them are dirty/conflicting. I’d keep this issue open until there is a clean fix in
dev.alfredocristofano commentedon Apr 27, 2026
Update: I cleaned up #24331 and force-pushed it onto current
dev. The diff is now 10 files and no longer includes the unrelated import/barrel changes.I also closed #24502, #24503, and #24504 because those branches had picked up large unrelated diffs and conflicts. Keeping #24331 as the cleaner path for this issue.
github-actions commentedon Jul 4, 2026
To stay organized issues are automatically closed after 60 days of no activity. If the issue is still relevant please open a new one.