You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just went through the link issue, and I don't think it's fixed. ( The PR was closed.)
If the expectation is to use zip.js, would it be safe to assume it'll be used for both Windows and Unix platforms? Would you also like me to continue with the PR to achieve this?
Activity
github-actions commentedon Aug 29, 2025
This issue might be a duplicate of existing issues. Please check:
Feel free to ignore if none of these address your specific case.
[-]no check if unzip is insalled[/-][+]no check if unzip is installed[/+]vickywane commentedon Sep 22, 2025
@rekram1-node I'd love to work on this.
Should unzip be automatically installed if not found?
Cc: @thdxr
rekram1-node commentedon Sep 22, 2025
@vickywane Instead of automatically installing unzip, I'm thinking we should fall back to using tar when unzip isn't available.
vickywane commentedon Sep 22, 2025
Okay, that sounds like a good idea.
I can work on a PR to implement that.
vickywane commentedon Oct 12, 2025
@rekram1-node I've fixed this in this PR
rekram1-node commentedon Oct 12, 2025
@vickywane btw your fix doesn't fix this issue unfortunately
This is an issue w/ the install script, I was saying it should fall back to tar (if it doesn't, maybe this was fixed since issue was made): https://github.com/sst/opencode/blob/afb406c5ff4fddfa18239b290a5a3f568bf0ed63/install#L97
For what you did in your PR that is actually really good BUT we need to actually do a slightly different solution for windows compat
We actually have a separate issue tracking what you tried to fix: #967
We want to replace all unzip invocations in lsp install with zip js
vickywane commentedon Oct 12, 2025
Oh, I see @rekram1-node
I just went through the link issue, and I don't think it's fixed. ( The PR was closed.)
If the expectation is to use zip.js, would it be safe to assume it'll be used for both Windows and Unix platforms? Would you also like me to continue with the PR to achieve this?
rekram1-node commentedon Oct 12, 2025
yes @vickywane that pr was closed because the llm didnt understand the goal haha
And yes using zipjs is compatible on both platforms
Btw dont feel pressured to open a pr but if you are happy to ill give some guidance:
clear the bin dir that lsps are installed in then:
bun run dev debug lsp diagnostics
^ should install lsp if not installed
vickywane commentedon Oct 12, 2025
Haha
I'm happy to give it a shot!
Will read through the existing usages of zip.js
(Thanks for the suoerfast responses btw)
rekram1-node commentedon Oct 12, 2025
ofc!
rekram1-node commentedon Oct 25, 2025
@vickywane no rush are you still wanting to tackle this?