You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Empty catch blocks hide errors in cleanup operations #18239
Several catch blocks in the codebase are empty, silently ignoring errors during cleanup operations (killing processes, destroying services). This makes debugging difficult when cleanup fails.
try{process.kill(dpid,"SIGTERM")}catch{}// Error is completely hidden
Expected Behavior
These errors should be logged at debug level so developers can see what's happening during cleanup, even when failures are expected (e.g., process already exited).
Proposed Solution
Add debug logging to these catch blocks:
try{process.kill(dpid,"SIGTERM")}catch(err){log.debug("Failed to kill descendant process",{pid: dpid,error: err})}
Impact
Low impact: These are cleanup operations where failures are often expected
Activity
github-actions commentedon Jul 3, 2026
To stay organized issues are automatically closed after 60 days of no activity. If the issue is still relevant please open a new one.