Repository navigation
Wrapper reports signal-based child termination as exit code 0 #17978
Description
Description
When the Node wrapper in packages/opencode/bin/opencode launches a child that terminates via signal, it can report exit code 0.
The current wrapper does this:
const code = typeof result.status === "number" ? result.status : 0
process.exit(code)For spawnSync, result.status is null and result.signal is set when the child terminates via signal. That makes an abnormal termination look like a clean exit to supervisors and scripts.
This is related to #17854, #15558, and #2489, but it is a different path. Those issues are about opencode run returning 0 for application-level failures. This issue is specifically about the outer wrapper converting signal-based child termination into 0 before the caller ever sees the real signal.
Plugins
No response
OpenCode version
1.2.27 (also reproducible on current dev)
Steps to reproduce
- Run:
node -e 'const cp=require("child_process"); const r=cp.spawnSync(process.env.SHELL||"bash",["-lc","kill -TERM $$"],{stdio:"inherit"}); console.log({status:r.status, signal:r.signal})' - Observe that
spawnSyncreportsstatus: nulland a non-nullsignalwhen the child dies from a signal. - Compare that with the current wrapper logic in
packages/opencode/bin/opencode, which maps the same case to exit code0. - Expected: the wrapper should preserve the signal or at least exit non-zero.
Screenshot and/or share link
No response
Operating System
macOS 15.5 arm64
Terminal
Ghostty
Metadata
Metadata
Assignees
Labels
No labels
Activity
github-actions commentedon Mar 17, 2026
This issue doesn't fully meet our contributing guidelines.
What needs to be fixed:
Please edit this issue to address the above within 2 hours, or it will be automatically closed.
This issue might be a duplicate of existing issues. Please check:
If you believe this was flagged incorrectly, please let a maintainer know.
github-actions commentedon Mar 17, 2026
Thank you for updating the issue! It now includes all the required information — a clear description, steps to reproduce, version, OS, and terminal. The compliance label has been removed.
chubes4 commentedon May 8, 2026
I opened a PR that fixes this wrapper path as part of the same root cause: #26259
The current wrapper has two related signal bugs:
spawnSync(), so the wrapper cannot forwardSIGTERM/SIGINT/SIGHUPwhile the child is running. If a supervisor kills the wrapper, the real.opencodechild can survive and become a PID-1 orphan.spawnSync()reports signal exits asstatus: nullwithsignalset, and the wrapper currently maps that to exit code0.The PR switches to async
spawn(), forwards standard termination signals to the child, and when the child exits due to a signal, re-raises that signal on the wrapper process instead of converting it to0.Verification:
8d26c4f6-4e90-459b-a15d-49e76cc0f9dabdc45e95-2ec3-44bf-b50a-c7daee37552eSignals tested:
SIGTERM,SIGINT,SIGHUP.