@@ -903,6 +903,8 @@ describe("V1Migration database workflow", () => {
903903 )
904904
905905 test ( "preserves 1.19 API messages while migrating legacy sessions in the same database" , async ( ) => {
906+ await using tmp = await tmpdir ( )
907+ await initRepo ( tmp . path )
906908 await run (
907909 Effect . gen ( function * ( ) {
908910 const db = yield * makeDb
@@ -914,12 +916,12 @@ describe("V1Migration database workflow", () => {
914916 )
915917 yield * db . run ( sql `
916918 INSERT INTO project (id, worktree, time_created, time_updated, sandboxes)
917- VALUES ('project', '/tmp/test ', 1, 2, '[]')
919+ VALUES ('project', ${ tmp . path } , 1, 2, '[]'), ('global', '/ ', 1, 2, '[]')
918920 ` )
919921 yield * db . run ( sql `
920922 INSERT INTO session (id, project_id, slug, directory, title, version, cost, tokens_input,
921923 agent, model, metadata, time_created, time_updated)
922- VALUES ('ses_native', 'project ', 'native', '/ tmp/test' , 'API history', '1.19.3', 2.25, 42,
924+ VALUES ('ses_native', 'global ', 'native', ${ tmp . path } , 'API history', '1.19.3', 2.25, 42,
923925 'build', '{"id":"model","providerID":"provider"}', '{"keep":true}', 1, 2),
924926 ('ses_test', 'project', 'legacy', '/tmp/test', 'Legacy history', '1.19.3', 0, 0,
925927 NULL, NULL, NULL, 1, 2)
@@ -941,19 +943,50 @@ describe("V1Migration database workflow", () => {
941943 VALUES ('prt_1', ${ source . id } , 'ses_test', 1, 2, ${ sourcePart . data } )
942944 ` )
943945
946+ // A legacy session can later be continued through the 1.19 API.
947+ yield * db . run ( sql `
948+ INSERT INTO session_message (id, session_id, type, seq, time_created, time_updated, data)
949+ VALUES ('msg_mixed', 'ses_test', 'user', 0, 20, 21, ${ data } )
950+ ` )
951+ yield * db . run ( sql `
952+ INSERT INTO session (id, project_id, slug, directory, title, version, time_created, time_updated)
953+ VALUES ('ses_relative', 'project', 'relative', '.', 'Relative', '1.19.3', 1, 2)
954+ ` )
955+ yield * db . run ( sql `
956+ INSERT INTO session_message (id, session_id, type, seq, time_created, time_updated, data)
957+ VALUES ('msg_relative', 'ses_relative', 'user', 0, 3, 4, ${ data } )
958+ ` )
959+ yield * db . run ( sql `
960+ INSERT INTO message (id, session_id, time_created, time_updated, data)
961+ VALUES ('msg_relative', 'ses_relative', 10, 11, ${ source . data } )
962+ ` )
944963 yield * DatabaseMigration . apply ( db )
945- expect ( yield * db . get ( sql `SELECT id, seq, data FROM session_message WHERE session_id = 'ses_native'` ) ) . toEqual ( {
946- id : "msg_native" ,
947- seq : 7 ,
948- data,
949- } )
950- yield * V1Migration . run ( ) . pipe (
964+ yield * db . run ( sql `
965+ CREATE TRIGGER fail_native BEFORE INSERT ON session_message
966+ WHEN NEW.id = 'msg_native' BEGIN SELECT RAISE(ABORT, 'stop'); END
967+ ` )
968+ const migrate = V1Migration . run ( ) . pipe (
951969 Effect . provide (
952970 AppNodeBuilder . build ( LayerNode . group ( [ Project . node , Database . node , FSUtil . node ] ) , [
953971 Database . node . replace ( Layer . succeed ( Database . Service , { db } ) ) ,
954972 ] ) ,
955973 ) ,
956974 )
975+ expect ( ( yield * Effect . exit ( migrate ) ) . _tag ) . toBe ( "Failure" )
976+ expect ( yield * db . get ( sql `SELECT id FROM session_v2 WHERE id = 'ses_native'` ) ) . toBeUndefined ( )
977+ expect ( yield * db . get ( sql `SELECT value FROM kv WHERE key = 'migration.v1-v2'` ) ) . toEqual ( {
978+ value : '{"phase":"sessions","cursor":"ses_relative"}' ,
979+ } )
980+ expect (
981+ yield * db . get ( sql `SELECT id, seq, data FROM migration_v1_session_message WHERE session_id = 'ses_native'` ) ,
982+ ) . toEqual ( {
983+ id : "msg_native" ,
984+ seq : 7 ,
985+ data,
986+ } )
987+ yield * db . run ( sql `DROP TRIGGER fail_native` )
988+ expect ( yield * migrate ) . toEqual ( { status : "completed" } )
989+ expect ( yield * migrate ) . toEqual ( { status : "completed" } )
957990
958991 expect ( yield * db . all ( sql `SELECT id, seq, data FROM session_message WHERE session_id = 'ses_native'` ) ) . toEqual ( [
959992 { id : "msg_native" , seq : 7 , data } ,
@@ -970,10 +1003,31 @@ describe("V1Migration database workflow", () => {
9701003 model : '{"id":"model","providerID":"provider"}' ,
9711004 metadata : '{"keep":true}' ,
9721005 } )
1006+ const owner = yield * db . get < { id : string } > (
1007+ sql `SELECT id FROM project WHERE worktree = ${ tmp . path } AND id <> 'project'` ,
1008+ )
1009+ expect ( owner ) . toBeDefined ( )
1010+ expect ( yield * db . get ( sql `SELECT project_id, path FROM session_v2 WHERE id = 'ses_native'` ) ) . toEqual ( {
1011+ project_id : owner ?. id ,
1012+ path : "" ,
1013+ } )
1014+ expect ( yield * db . get ( sql `SELECT directory FROM session_v2 WHERE id = 'ses_relative'` ) ) . toEqual ( {
1015+ directory : tmp . path ,
1016+ } )
1017+ expect ( yield * db . get ( sql `SELECT id, data FROM session_message WHERE session_id = 'ses_relative'` ) ) . toEqual ( {
1018+ id : "msg_relative" ,
1019+ data,
1020+ } )
9731021 expect ( yield * db . get ( sql `SELECT seq FROM event_sequence WHERE aggregate_id = 'ses_native'` ) ) . toEqual ( { seq : 9 } )
974- expect ( yield * db . all ( sql `SELECT id, data FROM session_message WHERE session_id = 'ses_test'` ) ) . toEqual ( [
1022+ expect (
1023+ yield * db . all ( sql `SELECT id, data FROM session_message WHERE session_id = 'ses_test' ORDER BY seq` ) ,
1024+ ) . toEqual ( [
9751025 { id : source . id , data : '{"text":"legacy text","time":{"created":10}}' } ,
1026+ { id : "msg_mixed" , data } ,
9761027 ] )
1028+ expect (
1029+ yield * db . get ( sql `SELECT name FROM sqlite_master WHERE name = 'migration_v1_session_message'` ) ,
1030+ ) . toBeUndefined ( )
9771031 expect ( yield * db . get ( sql `SELECT value FROM kv WHERE key = 'migration.v1-v2'` ) ) . toEqual ( {
9781032 value : '{"phase":"completed"}' ,
9791033 } )
0 commit comments