Skip to content

Commit d92a13d

Browse files
committed
perf(core): sleep on doorbell with zero timers or DB writes when no schedules are active
1 parent 505801d commit d92a13d

1 file changed

Lines changed: 30 additions & 0 deletions

File tree

‎packages/core/src/schedule.ts‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -544,8 +544,20 @@ const layer = Layer.effect(
544544
),
545545
)
546546

547+
const hasActiveRows = db
548+
.select({ id: ScheduleTable.id })
549+
.from(ScheduleTable)
550+
.where(eq(ScheduleTable.status, "active"))
551+
.limit(1)
552+
.get()
553+
.pipe(
554+
Effect.orDie,
555+
Effect.map((row) => row !== undefined),
556+
)
557+
547558
const ownerID = randomUUID()
548559
let leading = false
560+
let bootChecked = false
549561

550562
const claimLeader = Effect.fnUntraced(function* (now: number) {
551563
const value = { owner: ownerID, until: now + LEADER_TTL }
@@ -583,24 +595,42 @@ const layer = Layer.effect(
583595

584596
const loop = Effect.gen(function* () {
585597
yield* doorbell.close
598+
const active = yield* hasActiveRows
599+
if (!active && bootChecked) {
600+
if (leading) yield* releaseLeader
601+
yield* doorbell.await
602+
return
603+
}
586604
const now = yield* Clock.currentTimeMillis
587605
const isLeader = yield* claimLeader(now)
588606
if (!isLeader) {
589607
leading = false
608+
bootChecked = true
590609
yield* doorbell.await.pipe(Effect.timeoutOption(MAX_SLEEP))
591610
return
592611
}
593612
if (!leading) {
594613
leading = true
614+
bootChecked = true
595615
yield* rewake.pipe(Effect.catchCause((cause) => Effect.logError("schedule rewake failed", { cause })))
596616
}
617+
if (!active) {
618+
yield* releaseLeader
619+
yield* doorbell.await
620+
return
621+
}
597622
yield* Effect.scoped(
598623
Effect.forkScoped(heartbeat).pipe(
599624
Effect.andThen(
600625
tickAt(now).pipe(Effect.catchCause((cause) => Effect.logError("schedule tick failed", { cause }))),
601626
),
602627
),
603628
)
629+
if (!(yield* hasActiveRows)) {
630+
yield* releaseLeader
631+
yield* doorbell.await
632+
return
633+
}
604634
const wait = yield* nextWake(now)
605635
if (wait > 0) yield* doorbell.await.pipe(Effect.timeoutOption(wait))
606636
})

0 commit comments

Comments
 (0)