Repository navigation
Commit d3c7736
committed
fix(server): revert structured validation error wire format (#26457)
PR #26457 changed the 400 wire format on the HTTP API in three ways:
1. \`Effect.catch(HttpApiError.BadRequest)\` → \`{ data: {}, errors: [], success: false }\`
2. \`HttpApiSchemaError\` defect → same shape
3. \`normalizeEmptyBadRequest\` post-processor that rewrites ANY empty
400 into the same shape
In v1.14.42 (post-Hono-deletion) at least one external plugin
(\`opencode-gemini-auth\`, per #26546 reports) makes an HTTP API call
during startup that hits one of these paths and breaks on the new
body shape — the unparseable JSON ends up printed to stdout and the
TUI never starts. \`opencode --pure\` works (no plugins), \`opencode run\`
works (no in-process server interaction), but \`opencode\` (TUI) crashes.
Revert all three changes from #26457. The default HttpApi serialization
of typed errors comes back, matching v1.14.41 wire format. We can
re-introduce structured validation responses behind an opt-in or
contract change once plugin authors have a chance to migrate.
Closes #26546.1 parent b1cd25d commit d3c7736
2 files changed
Lines changed: 1 addition & 47 deletions
File tree
- packages/opencode
- src/server/routes/instance/httpapi/middleware
- test/server
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | 9 | | |
12 | 10 | | |
13 | 11 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | 12 | | |
31 | 13 | | |
32 | 14 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | 15 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | 16 | | |
43 | 17 | | |
44 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
| |||
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | | - | |
18 | 16 | | |
19 | 17 | | |
20 | 18 | | |
| |||
121 | 119 | | |
122 | 120 | | |
123 | 121 | | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | 122 | | |
0 commit comments