Skip to content

Commit cd6e351

Browse files
committed
feat(app): add mobile session panels and detail drawers
OpenCode-Session: ses_fa9375bf2ffd1qwP3qNWRyj1dW OpenCode-Session: ses_fa8e8d9a1ffedn46jvXHQkVsgx OpenCode-Session: ses_fa8d40a0bffelgYWDAaU1XvYj8 OpenCode-Session: ses_fa8b885a0ffdKRQ0V2AMcGEu9a OpenCode-Session: ses_fa8c9b9c6ffeULe3oLIORr07X2 OpenCode-Session: ses_fa8b34988ffdpVySqqaO61cULj
1 parent b03c4f2 commit cd6e351

20 files changed

Lines changed: 1207 additions & 264 deletions
Lines changed: 110 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,110 @@
1+
import { expect, test } from "@playwright/test"
2+
import { fixture, pageMessages } from "../performance/timeline/session-timeline-stress.fixture"
3+
import { stressSessionHref } from "../performance/timeline/timeline-test-helpers"
4+
import { mockOpenCodeServer } from "../utils/mock-server"
5+
6+
for (const direction of ["ltr", "rtl"] as const) {
7+
test(`mobile files browse, search, switch, and close shared file tabs in ${direction}`, async ({ page }) => {
8+
await page.setViewportSize({ width: 390, height: 844 })
9+
await mockOpenCodeServer(page, {
10+
directory: fixture.directory,
11+
project: fixture.project,
12+
sessions: fixture.sessions,
13+
provider: fixture.provider,
14+
pageMessages,
15+
fileList: (path) =>
16+
path
17+
? []
18+
: ["first.ts", "second.ts"].map((name) => ({
19+
name,
20+
path: name,
21+
absolute: `${fixture.directory}/${name}`,
22+
type: "file",
23+
ignored: false,
24+
})),
25+
fileContent: (path) => `contents:${path}`,
26+
findFiles: ({ query }) => ["first.ts", "second.ts"].filter((path) => path.includes(query)),
27+
})
28+
await page.goto(stressSessionHref(fixture.targetID))
29+
const navigation = page.getByRole("tablist", { name: "Session view", exact: true })
30+
await navigation.getByRole("tab", { name: "Files", exact: true }).click()
31+
const files = page.locator('[data-slot="session-mobile-files"]')
32+
await expect(files.getByRole("button", { name: "first.ts", exact: true })).toBeVisible()
33+
await page.evaluate((direction) => (document.documentElement.dir = direction), direction)
34+
await expect(files.locator('[data-slot="session-mobile-files-header"]')).toHaveCSS("border-bottom-width", "0px")
35+
await expect
36+
.poll(() =>
37+
files.getByRole("tablist", { name: "Open files", exact: true }).evaluate((element) => {
38+
const header = element.closest('[data-slot="session-mobile-files-header"]')!
39+
const separator = getComputedStyle(element, "::before")
40+
return {
41+
height: separator.height,
42+
fullWidth: parseFloat(separator.width) === header.clientWidth,
43+
start: separator.insetInlineStart,
44+
bottom: separator.bottom,
45+
}
46+
}),
47+
)
48+
.toEqual({ height: "1px", fullWidth: true, start: "0px", bottom: "0px" })
49+
await files.getByRole("button", { name: "first.ts", exact: true }).click()
50+
await expect(files.getByText("contents:first.ts", { exact: true })).toBeVisible()
51+
await files.locator('[data-column-number="1"]').click()
52+
const editor = files.locator('[data-component="line-comment-v2"][data-variant="editor"]')
53+
await expect(editor.getByRole("textbox")).toBeVisible()
54+
for (const width of [390, 700]) {
55+
await page.setViewportSize({ width, height: 844 })
56+
await expect
57+
.poll(async () => {
58+
const panel = await files.boundingBox()
59+
const comment = await editor.boundingBox()
60+
if (!panel || !comment) return false
61+
return Math.abs(comment.x - panel.x - 12) < 2 && Math.abs(comment.width - panel.width + 24) < 2
62+
})
63+
.toBe(true)
64+
}
65+
await editor.getByRole("textbox").fill("Full-width file comment")
66+
await editor.getByRole("button", { name: "Comment", exact: true }).click()
67+
const comment = files.locator('[data-component="line-comment-v2"][data-variant="display"]')
68+
await expect(comment).toContainText("Full-width file comment")
69+
await expect
70+
.poll(async () => {
71+
const panel = await files.boundingBox()
72+
const card = await comment.boundingBox()
73+
if (!panel || !card) return false
74+
return Math.abs(card.x - panel.x - 12) < 2 && Math.abs(card.width - panel.width + 24) < 2
75+
})
76+
.toBe(true)
77+
await page.setViewportSize({ width: 390, height: 844 })
78+
await expect(files.getByRole("combobox", { name: "Filter files", exact: true })).toBeHidden()
79+
await files.getByRole("button", { name: "All files", exact: true }).click()
80+
await files.getByRole("combobox", { name: "Filter files", exact: true }).fill("second")
81+
await files.getByRole("option", { name: "second.ts", exact: true }).click()
82+
await expect(files.getByText("contents:second.ts", { exact: true })).toBeVisible()
83+
const openTabs = files.getByRole("tablist", { name: "Open files", exact: true })
84+
await expect(openTabs.getByRole("tab")).toHaveText(["first.ts", "second.ts"])
85+
await expect
86+
.poll(() =>
87+
openTabs.getByRole("tab", { name: "second.ts", exact: true }).evaluate((element) => {
88+
const tab = element.closest('[data-slot="tabs-v2-trigger-wrapper"]')!
89+
const header = element.closest('[data-slot="session-mobile-files-header"]')!
90+
return Math.abs(tab.getBoundingClientRect().bottom - header.getBoundingClientRect().bottom) < 1
91+
}),
92+
)
93+
.toBe(true)
94+
await openTabs.getByRole("tab", { name: "first.ts", exact: true }).click()
95+
await expect(files.getByText("contents:first.ts", { exact: true })).toBeVisible()
96+
await navigation.getByRole("tab", { name: "Session", exact: true }).click()
97+
await navigation.getByRole("tab", { name: "Files", exact: true }).click()
98+
await expect(files.getByText("contents:first.ts", { exact: true })).toBeVisible()
99+
await files
100+
.locator('[data-slot="tabs-v2-trigger-wrapper"]')
101+
.filter({ has: page.getByRole("tab", { name: "first.ts", exact: true }) })
102+
.getByRole("button", { name: "Close tab", exact: true })
103+
.click()
104+
await expect(openTabs.getByRole("tab")).toHaveText(["second.ts"])
105+
await expect(files.getByText("contents:second.ts", { exact: true })).toBeVisible()
106+
await files.getByRole("button", { name: "Close tab", exact: true }).click()
107+
await expect(files.getByRole("combobox", { name: "Filter files", exact: true })).toBeVisible()
108+
await expect(openTabs.getByRole("tab")).toHaveCount(0)
109+
})
110+
}
Lines changed: 183 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,183 @@
1+
import { expect, test } from "@playwright/test"
2+
import { fixture, pageMessages } from "../performance/timeline/session-timeline-stress.fixture"
3+
import { installStressSessionTabs, stressSessionHref } from "../performance/timeline/timeline-test-helpers"
4+
import { mockOpenCodeServer } from "../utils/mock-server"
5+
6+
for (const position of ["top", "bottom"] as const) {
7+
test(`mobile session tabs switch views and keep the terminal cached with ${position} navigation`, async ({
8+
page,
9+
}) => {
10+
await page.setViewportSize({ width: 390, height: 844 })
11+
await mockOpenCodeServer(page, {
12+
directory: fixture.directory,
13+
project: fixture.project,
14+
sessions: fixture.sessions,
15+
provider: fixture.provider,
16+
pageMessages,
17+
fileList: () => [],
18+
})
19+
await installStressSessionTabs(page)
20+
await page.addInitScript(
21+
(position) =>
22+
localStorage.setItem("settings.v3", JSON.stringify({ general: { mobileTitlebarPosition: position } })),
23+
position,
24+
)
25+
await page.route("**/api/pty*", (route) =>
26+
route.fulfill({
27+
json: {
28+
location: { directory: fixture.directory, project: { id: fixture.project.id, directory: fixture.directory } },
29+
data: {
30+
id: "pty_mobile_views",
31+
title: "Terminal 1",
32+
command: "sh",
33+
args: [],
34+
cwd: fixture.directory,
35+
status: "running",
36+
pid: 1,
37+
},
38+
},
39+
}),
40+
)
41+
await page.routeWebSocket("**/api/pty/pty_mobile_views/connect", () => undefined)
42+
await page.route("**/api/pty/pty_mobile_views/connect-token*", (route) =>
43+
route.fulfill({
44+
json: {
45+
location: { directory: fixture.directory, project: { id: fixture.project.id, directory: fixture.directory } },
46+
data: { ticket: "e2e-ticket", expires_in: 60 },
47+
},
48+
}),
49+
)
50+
await page.goto(stressSessionHref(fixture.targetID))
51+
52+
const tabs = page.getByRole("tablist", { name: "Session view", exact: true })
53+
const navigation = page.locator('[data-slot="session-mobile-view-navigation"]')
54+
const more = navigation.getByRole("button", { name: "More options", exact: true })
55+
const picker = tabs.getByRole("tab", { selected: true })
56+
const message = page.locator(
57+
`[data-timeline-row="UserMessage"][data-message-id="${fixture.expected.targetMessageIDs.at(-1)}"]`,
58+
)
59+
const composer = page.getByRole("textbox", { name: "Prompt", exact: true })
60+
await expect(picker).toHaveText("Session")
61+
await expect(message).toBeVisible()
62+
await expect(composer).toBeVisible()
63+
await expect(tabs.getByRole("tab")).toHaveText(["Session", "Changes", "Files", "Terminal"])
64+
await expect(tabs).toHaveCSS("padding-left", "0px")
65+
await expect(tabs).toHaveCSS("padding-right", "0px")
66+
await expect
67+
.poll(async () => {
68+
const bounds = await navigation.boundingBox()
69+
return !!bounds && bounds.x >= 8 && bounds.x <= 9 && bounds.width >= 372 && bounds.width <= 374
70+
})
71+
.toBe(true)
72+
await expect
73+
.poll(async () => {
74+
const bar = await tabs.boundingBox()
75+
const input = await composer.boundingBox()
76+
return (
77+
!!bar && !!input && (position === "bottom" ? bar.y >= input.y + input.height : bar.y + bar.height <= input.y)
78+
)
79+
})
80+
.toBe(true)
81+
await expect(page.locator("[data-session-title]")).toHaveCount(0)
82+
await expect(page.locator('[data-slot="mobile-tabs-trigger"]')).toContainText(fixture.expected.targetTitle)
83+
await page.getByRole("button", { name: "Tabs", exact: true }).click()
84+
const drawer = page.getByRole("dialog", { name: "Tabs", exact: true })
85+
await expect(drawer).toHaveAttribute("data-open", "")
86+
await expect(drawer).not.toHaveAttribute("data-transitioning")
87+
await expect(drawer.getByRole("button", { name: "Settings", exact: true })).toBeInViewport()
88+
await drawer.getByRole("button", { name: "Settings", exact: true }).click()
89+
await expect(page.getByTestId("settings-screen")).toBeVisible()
90+
await page.getByRole("button", { name: "Back to app", exact: true }).click()
91+
await page.getByRole("button", { name: "Tabs", exact: true }).click()
92+
await expect(drawer).not.toHaveAttribute("data-transitioning")
93+
await expect(drawer.getByRole("button", { name: "Settings", exact: true })).toBeInViewport()
94+
await page.keyboard.press("Escape")
95+
await expect(drawer).toBeHidden()
96+
97+
await more.click()
98+
await page.getByRole("menuitem", { name: "Usage", exact: true }).click()
99+
await expect(picker).toHaveCount(0)
100+
await expect(page.getByText("Total Cost", { exact: true })).toBeVisible()
101+
await expect(composer).toBeHidden()
102+
103+
await more.click()
104+
await page.getByRole("menuitem", { name: "Status", exact: true }).click()
105+
const status = page.getByRole("dialog", { name: "Status", exact: true })
106+
await expect(status.getByRole("tab", { name: "MCP", exact: true })).toBeVisible()
107+
await status.getByRole("tab", { name: "Plugins", exact: true }).click()
108+
await expect(status.getByText("opencode.json", { exact: true })).toBeVisible()
109+
await status.getByRole("button", { name: "Close", exact: true }).click()
110+
await expect(status).toBeHidden()
111+
await expect(more).toBeFocused()
112+
113+
await more.click()
114+
await page.getByRole("menuitem", { name: "Session details", exact: true }).click()
115+
const details = page.getByRole("dialog", { name: "Session details", exact: true })
116+
await expect(details.getByText(fixture.project.name, { exact: true })).toBeVisible()
117+
await expect(details.getByRole("button", { name: "No changes", exact: true })).toBeVisible()
118+
await details.getByRole("button", { name: "Close", exact: true }).click()
119+
await expect(details).toBeHidden()
120+
await expect(more).toBeFocused()
121+
await more.click()
122+
await page.getByRole("menuitem", { name: "Session details", exact: true }).click()
123+
await expect(details.getByRole("button", { name: "No changes", exact: true })).toBeVisible()
124+
await expect(details).not.toHaveAttribute("data-transitioning")
125+
await page.keyboard.press("Escape")
126+
await expect(details).toBeHidden()
127+
await expect(more).toBeFocused()
128+
await more.click()
129+
await page.getByRole("menuitem", { name: "Session details", exact: true }).click()
130+
await details.getByRole("button", { name: "No changes", exact: true }).click()
131+
await expect(details).toBeHidden()
132+
await expect(picker).toHaveText("Changes")
133+
await expect(page.getByText("No uncommitted changes yet", { exact: true })).toBeVisible()
134+
await expect(page.locator('[data-slot="session-review-header"]')).toHaveCSS("height", "40px")
135+
await expect(page.locator('[data-slot="session-review-header"]')).toHaveCSS("padding-left", "8px")
136+
await expect(composer).toBeHidden()
137+
138+
await tabs.getByRole("tab", { name: "Files", exact: true }).click()
139+
await expect(picker).toHaveText("Files")
140+
await expect(page.getByRole("combobox", { name: "Filter files", exact: true })).toBeVisible()
141+
await expect(composer).toBeHidden()
142+
143+
await tabs.getByRole("tab", { name: "Terminal", exact: true }).click()
144+
const panel = page.locator("#terminal-panel")
145+
await expect(panel).toHaveAttribute("data-opened", "true")
146+
await expect(panel.getByRole("tab", { name: /Terminal 1/ })).toBeVisible()
147+
await expect(panel.locator('[data-component="terminal"]')).toBeVisible()
148+
await expect(panel.locator("textarea")).toBeEditable()
149+
await expect(panel).toHaveCount(1)
150+
await panel.evaluate((element) => element.setAttribute("data-cache-probe", "original"))
151+
await expect(composer).toBeHidden()
152+
153+
await tabs.getByRole("tab", { name: "Session", exact: true }).click()
154+
await expect(message).toBeVisible()
155+
await expect(panel).toBeHidden()
156+
await expect(panel).toHaveAttribute("inert", "")
157+
await expect(panel).toHaveAttribute("data-cache-probe", "original")
158+
159+
await page.keyboard.press("Control+Backquote")
160+
await expect(picker).toHaveText("Terminal")
161+
await expect(panel).toBeVisible()
162+
await expect(panel).toHaveAttribute("data-cache-probe", "original")
163+
await page.keyboard.press("Control+Backquote")
164+
await expect(picker).toHaveText("Session")
165+
166+
await page.keyboard.press("Control+Backquote")
167+
await expect(picker).toHaveText("Terminal")
168+
await panel.getByRole("button", { name: "Close terminal", exact: true }).click()
169+
await expect(picker).toHaveText("Session")
170+
await expect(panel).toBeHidden()
171+
172+
await more.click()
173+
await page.getByRole("menuitem", { name: "Usage", exact: true }).click()
174+
await expect(page.getByText("Total Cost", { exact: true })).toBeVisible()
175+
await page.goto(stressSessionHref(fixture.sourceID))
176+
await expect(picker).toHaveText("Session")
177+
await expect(page.locator('[data-slot="mobile-tabs-trigger"]')).toContainText(fixture.expected.sourceTitle)
178+
179+
await page.setViewportSize({ width: 1280, height: 900 })
180+
await expect(picker).toBeHidden()
181+
await expect(page.locator("[data-session-title]")).toBeVisible()
182+
})
183+
}
Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
import { expect, test } from "@playwright/test"
2+
import { fixture } from "../performance/timeline/session-timeline-stress.fixture"
3+
import { mockStressTimeline, stressSessionHref } from "../performance/timeline/timeline-test-helpers"
4+
5+
test("status drawer dismisses and reopens after button, backdrop, Escape, and drag", async ({ page }) => {
6+
await page.setViewportSize({ width: 390, height: 844 })
7+
await mockStressTimeline(page)
8+
await page.goto(stressSessionHref(fixture.targetID))
9+
const more = page
10+
.locator('[data-slot="session-mobile-view-navigation"]')
11+
.getByRole("button", { name: "More options", exact: true })
12+
const drawer = page.getByRole("dialog", { name: "Status", exact: true })
13+
const overlay = page.locator('[data-slot="mobile-status-overlay"]')
14+
15+
for (const dismissal of ["button", "backdrop", "escape", "drag", "button"] as const) {
16+
await more.click()
17+
await page.getByRole("menuitem", { name: "Status", exact: true }).click()
18+
await expect(drawer.getByRole("tab", { name: "MCP", exact: true })).toBeVisible()
19+
await expect(drawer).not.toHaveAttribute("data-transitioning")
20+
if (dismissal === "button") await drawer.getByRole("button", { name: "Close", exact: true }).click()
21+
if (dismissal === "backdrop") await overlay.click({ position: { x: 10, y: 10 } })
22+
if (dismissal === "escape") await page.keyboard.press("Escape")
23+
if (dismissal === "drag") {
24+
const handle = drawer.locator('[data-slot="mobile-status-drag-handle"]')
25+
const bounds = await handle.boundingBox()
26+
expect(bounds).not.toBeNull()
27+
await page.mouse.move(bounds!.x + bounds!.width / 2, bounds!.y + bounds!.height / 2)
28+
await page.mouse.down()
29+
await page.mouse.move(bounds!.x + bounds!.width / 2, bounds!.y + bounds!.height / 2 + 1)
30+
await page.mouse.move(bounds!.x + bounds!.width / 2, 843)
31+
await page.mouse.up()
32+
}
33+
await expect(drawer, `dismissal: ${dismissal}`).toBeHidden()
34+
await expect(overlay).toHaveCount(0)
35+
await expect(more).toBeFocused()
36+
}
37+
})

‎packages/app/src/runtime/i18n/en.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -660,6 +660,10 @@ export const dict = {
660660
"home.providerTip": "Connect to 75+ providers to use other models, including Claude, GPT, Gemini, etc",
661661

662662
"session.tab.session": "Session",
663+
"session.tab.files": "Files",
664+
"session.files.openTabs": "Open files",
665+
"session.tab.usage": "Usage",
666+
"session.view.select": "Session view",
663667
"session.tab.review": "Review",
664668
"session.tab.context": "Context",
665669
"session.tab.unknown": "Unknown Session",

‎packages/app/src/session/files/session-context-tab.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ export function SessionContextTab() {
271271
}}
272272
onScroll={handleScroll}
273273
>
274-
<div class="px-6 pt-4 pb-10 flex flex-col gap-10">
274+
<div class="px-2 pt-2 pb-6 flex flex-col gap-6 md:px-6 md:pt-4 md:pb-10 md:gap-10">
275275
<div class="grid grid-cols-1 @[32rem]:grid-cols-2 gap-4">
276276
<For each={stats}>
277277
{(stat) => <Stat label={language.t(stat.label as Parameters<typeof language.t>[0])} value={stat.value()} />}

0 commit comments

Comments
 (0)