Repository navigation
Commit cb7650c
committed
fix(plugin): yield the prompt-hook registration so the reminder actually lands
The prompt hook was registered without yield*, and hook only registers when
its returned Effect runs (PluginHooks.register) - so the hook never landed,
the #58287 repro still made the second, unprompted request, and the PR
behaved exactly like the base. The registration is yielded now, and the
test stub records the callback only when the returned Effect runs (matching
real registration), so the new tests fail without the yield* instead of
passing vacuously.1 parent 364b1fd commit cb7650c
2 files changed
Lines changed: 12 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
65 | 67 | | |
66 | 68 | | |
67 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
102 | 106 | | |
103 | 107 | | |
104 | 108 | | |
| |||
0 commit comments