File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -64,9 +64,11 @@ const baseLayer = Layer.effect(
6464 const location = yield * Location . Service
6565 const search = yield * FileSystemSearch . Service
6666 // Workspace-placed directories exist only inside the workspace, so a host
67- // realpath probe consults the wrong filesystem and would block boot on
68- // servers without a matching local directory. Treat the configured
69- // directory as canonical; local placements keep symlink canonicalization.
67+ // realpath probe at boot consults the wrong filesystem and would block
68+ // construction on servers without a matching local directory. Treat the
69+ // configured directory as canonical; local placements keep symlink
70+ // canonicalization. This skip is boot-only: resolve/read/list below still
71+ // access the host filesystem per operation (tracked in #44568).
7072 const root = location . workspaceID ? location . directory : yield * fs . realPath ( location . directory ) . pipe ( Effect . orDie )
7173 const resolve = Effect . fnUntraced ( function * ( input ?: RelativePath ) {
7274 const absolute = path . resolve ( location . directory , input ?? "." )
Original file line number Diff line number Diff line change @@ -63,8 +63,9 @@ describe("FileSystem", () => {
6363 it . live ( "skips host canonicalization for workspace locations at boot" , ( ) =>
6464 withTmp ( ( directory ) =>
6565 Effect . gen ( function * ( ) {
66- // The directory exists only inside the workspace, so booting the
67- // service must not probe the host filesystem.
66+ // The directory exists only inside the workspace, so boot must not
67+ // require it to exist on the host. Operations still access the host
68+ // filesystem per call (#44568); only boot canonicalization is skipped.
6869 const missing = path . join ( directory , "workspace-only" )
6970 const workspace = yield * FileSystem . Service . pipe (
7071 provide ( missing , Workspace . ID . make ( "wrk_filesystem" ) ) ,
You can’t perform that action at this time.
0 commit comments