Skip to content

Commit c32ded5

Browse files
committed
docs(core): scope boot-only canonicalization comments to #44568
1 parent 98c84e9 commit c32ded5

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

‎packages/core/src/filesystem.ts‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,11 @@ const baseLayer = Layer.effect(
6464
const location = yield* Location.Service
6565
const search = yield* FileSystemSearch.Service
6666
// Workspace-placed directories exist only inside the workspace, so a host
67-
// realpath probe consults the wrong filesystem and would block boot on
68-
// servers without a matching local directory. Treat the configured
69-
// directory as canonical; local placements keep symlink canonicalization.
67+
// realpath probe at boot consults the wrong filesystem and would block
68+
// construction on servers without a matching local directory. Treat the
69+
// configured directory as canonical; local placements keep symlink
70+
// canonicalization. This skip is boot-only: resolve/read/list below still
71+
// access the host filesystem per operation (tracked in #44568).
7072
const root = location.workspaceID ? location.directory : yield* fs.realPath(location.directory).pipe(Effect.orDie)
7173
const resolve = Effect.fnUntraced(function* (input?: RelativePath) {
7274
const absolute = path.resolve(location.directory, input ?? ".")

‎packages/core/test/location-filesystem.test.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,9 @@ describe("FileSystem", () => {
6363
it.live("skips host canonicalization for workspace locations at boot", () =>
6464
withTmp((directory) =>
6565
Effect.gen(function* () {
66-
// The directory exists only inside the workspace, so booting the
67-
// service must not probe the host filesystem.
66+
// The directory exists only inside the workspace, so boot must not
67+
// require it to exist on the host. Operations still access the host
68+
// filesystem per call (#44568); only boot canonicalization is skipped.
6869
const missing = path.join(directory, "workspace-only")
6970
const workspace = yield* FileSystem.Service.pipe(
7071
provide(missing, Workspace.ID.make("wrk_filesystem")),

0 commit comments

Comments
 (0)