Skip to content

Commit 93f30ca

Browse files
authored
feat(app): tweak interface layout with simpler previews (#61685)
1 parent 8568952 commit 93f30ca

8 files changed

Lines changed: 181 additions & 340 deletions

File tree

‎packages/app/e2e/regression/home.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ test("Home keeps the session list in every interface mode", async ({ page }) =>
3030
await page.keyboard.press("Control+,")
3131
const settings = page.getByTestId("settings-screen")
3232
const option = settings.getByRole("radio", { name: mode, exact: true })
33-
await settings.getByRole("group", { name: "Interface", exact: true }).getByText(mode, { exact: true }).click()
33+
await settings.getByRole("group", { name: "Interface layout", exact: true }).getByText(mode, { exact: true }).click()
3434
await expect(option).toBeChecked()
3535
await settings.getByRole("button", { name: "Back to app", exact: true }).click()
3636
await expect(page).toHaveURL("/")

‎packages/app/e2e/regression/settings.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1861,7 +1861,7 @@ test("a pairing code with several addresses keeps the first one that works with
18611861

18621862
test("the Side tabs interface mode switches to vertical tabs and survives reload", async ({ page }) => {
18631863
const { settings } = await open(page)
1864-
const layout = settings.getByRole("group", { name: "Interface" })
1864+
const layout = settings.getByRole("group", { name: "Interface layout", exact: true })
18651865
await expect(layout.getByRole("radio", { name: "Top tabs", exact: true })).toBeChecked()
18661866
await layout.getByText("Side tabs", { exact: true }).click()
18671867
await expect(layout.getByRole("radio", { name: "Side tabs", exact: true })).toBeChecked()

‎packages/app/src/runtime/i18n/en.ts‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -867,15 +867,11 @@ export const dict = {
867867
"settings.appearance.row.tabs.description": "Choose how session tabs are arranged",
868868
"settings.appearance.row.tabs.horizontal": "Horizontal",
869869
"settings.appearance.row.tabs.vertical": "Vertical",
870-
"settings.general.row.interfaceMode.title": "Interface",
870+
"settings.general.row.interfaceMode.title": "Interface layout",
871+
"settings.general.row.interfaceMode.description": "Choose how you switch between sessions and keep track of what's running",
871872
"settings.general.row.interfaceMode.top": "Top tabs",
872-
"settings.general.row.interfaceMode.top.description": "Browser-style tabs across the top of the window.",
873873
"settings.general.row.interfaceMode.side": "Side tabs",
874-
"settings.general.row.interfaceMode.side.description": "Browser-style tabs in a sidebar.",
875874
"settings.general.row.interfaceMode.inbox": "Inbox",
876-
"settings.general.row.interfaceMode.inbox.description":
877-
"Every session across your servers, sorted by what needs you next.",
878-
"settings.general.row.interfaceMode.experimental": "Experimental",
879875
"settings.appearance.row.zoom.title": "Zoom",
880876
"settings.appearance.row.zoom.description": "Make text and controls larger across the app",
881877
"settings.appearance.row.reduceMotion.title": "Reduce motion",

‎packages/app/src/settings/general/general.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,8 @@ export const SettingsGeneral: Component = () => {
263263
const GeneralSection = () => (
264264
<div class="settings-section">
265265
<h3 class="settings-section-title">{language.t("settings.general.section.general")}</h3>
266-
<InterfaceModeSetting />
267266
<SettingsList>
267+
<InterfaceModeSetting />
268268
<LanguageSetting />
269269

270270
<WorkspaceDestinationSetting />

0 commit comments

Comments
 (0)