Skip to content

Commit 8aebed1

Browse files
authored
fix(app): show empty review state for projects without VCS (#50265)
1 parent 14148a0 commit 8aebed1

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

‎packages/app/src/session/review/model.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,9 @@ export function createSessionReview(input: {
155155
const count = () => diffs().length
156156
const hasChanges = () => count() > 0
157157
const ready = () => {
158+
// A project without VCS never enables vcsQuery, so its status stays "pending" forever.
159+
const project = input.session.project()
160+
if (project && !project.vcs) return true
158161
if (mode() === "git" || mode() === "branch") return !vcsQuery.isPending
159162
return true
160163
}

‎packages/app/src/session/review/view.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ function ReviewTitle(props: { review: SessionReviewModel }) {
249249
function ReviewEmpty(props: { review: SessionReviewModel; loadingClass: string }) {
250250
const language = useLanguage()
251251
const loading = () => (props.review.mode() === "git" || props.review.mode() === "branch") && !props.review.ready()
252-
const noGit = () => props.review.mode() === "turn" && props.review.noGit()
252+
const noGit = () => props.review.noGit()
253253
const text = () => {
254254
if (props.review.mode() === "git") return language.t("session.review.noUncommittedChanges")
255255
if (props.review.mode() === "branch") return language.t("session.review.noBranchChanges")
@@ -282,7 +282,7 @@ function ReviewEmpty(props: { review: SessionReviewModel; loadingClass: string }
282282
function ReviewPanelEmpty(props: { review: SessionReviewModel }) {
283283
const language = useLanguage()
284284
const loading = () => (props.review.mode() === "git" || props.review.mode() === "branch") && !props.review.ready()
285-
const noGit = () => props.review.mode() === "turn" && props.review.noGit()
285+
const noGit = () => props.review.noGit()
286286
return (
287287
<Switch>
288288
<Match when={loading()}>

0 commit comments

Comments
 (0)