Skip to content

Commit 3533cd6

Browse files
committed
test(app): drop the wheel-navigation claim from the scroll benchmark
The comment blamed a wheel burst for the app navigating. The navigation was the load-time double navigation, and the destroyed context came from the settle loop never resolving because its budget was read from module scope. The assignment is kept because it lands deterministically, not because the wheel navigates.
1 parent 93bfc99 commit 3533cd6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎packages/app/e2e/performance/timeline/session-timeline-scroll-benchmark.spec.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ async function runTimelineScrollBenchmark(page: Page, options: { waitForColdSett
8787
* timeline, and the net movement is returned as-is: the cold tail pin can legitimately drag the
8888
* view back down.
8989
*
90-
* Assigns `scrollTop` rather than wheeling: a wheel burst makes this app navigate, which destroys
91-
* the execution context mid-measurement. The assignment still fires a real scroll event, so the
92-
* settle path under measurement runs unchanged.
90+
* Assigns `scrollTop` rather than wheeling, matching the fixture's own `scrollToBottom`. The
91+
* assignment still fires a real scroll event, so the settle path under measurement runs unchanged,
92+
* and each step lands deterministically instead of depending on wheel delivery.
9393
*/
9494
async function wheelThrough(scroller: Locator, steps: number, delta: number) {
9595
const start = await scroller.evaluate((element) => element.scrollTop)

0 commit comments

Comments
 (0)