Skip to content

Commit 3079fb4

Browse files
committed
fix(core): omit standalone signed-empty reasoning
1 parent 90cd910 commit 3079fb4

2 files changed

Lines changed: 44 additions & 3 deletions

File tree

‎packages/core/src/session/runner/to-llm-message.ts‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,10 +197,17 @@ const assistant = (message: SessionMessage.Assistant, model: Model.Ref, provider
197197
)
198198
return result ? [call, result] : [call]
199199
})
200+
const hasOutput = content.some((part) => {
201+
if (part.type === "text" || part.type === "reasoning") return part.text !== ""
202+
return true
203+
})
200204
const meaningful = content.filter((part) => {
201205
if (part.type === "text") return part.text !== ""
202206
if (part.type !== "reasoning") return true
203-
return part.text !== "" || (part.providerMetadata !== undefined && Object.keys(part.providerMetadata).length > 0)
207+
return (
208+
part.text !== "" ||
209+
(hasOutput && part.providerMetadata !== undefined && Object.keys(part.providerMetadata).length > 0)
210+
)
204211
})
205212
const results = message.content
206213
.filter((item): item is SessionMessage.AssistantTool => item.type === "tool" && item.executed !== true)

‎packages/core/test/session-runner-message.test.ts‎

Lines changed: 36 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,18 +68,52 @@ describe("toLLMMessages", () => {
6868
assistant("empty-text", [SessionMessage.AssistantText.make({ type: "text", text: "" })]),
6969
assistant("empty-reasoning", [SessionMessage.AssistantReasoning.make({ type: "reasoning", text: "" })]),
7070
assistant("text", [SessionMessage.AssistantText.make({ type: "text", text: "Partial" })]),
71-
assistant("reasoning", [
71+
assistant("signed-reasoning", [
7272
SessionMessage.AssistantReasoning.make({
7373
type: "reasoning",
7474
text: "",
7575
state: { signature: "sig_1" },
7676
}),
7777
]),
78+
assistant("signed-reasoning-with-text", [
79+
SessionMessage.AssistantReasoning.make({
80+
type: "reasoning",
81+
text: "",
82+
state: { signature: "sig_2" },
83+
}),
84+
SessionMessage.AssistantText.make({ type: "text", text: "Visible" }),
85+
]),
86+
assistant("signed-reasoning-with-tool", [
87+
SessionMessage.AssistantReasoning.make({
88+
type: "reasoning",
89+
text: "",
90+
state: { signature: "sig_3" },
91+
}),
92+
SessionMessage.AssistantTool.make({
93+
type: "tool",
94+
id: "read",
95+
name: "read",
96+
state: SessionMessage.ToolStateStreaming.make({ status: "streaming", input: '{"path":"README.md"}' }),
97+
time: { created },
98+
}),
99+
]),
78100
],
79101
model,
80102
)
81103

82-
expect(messages.map((message) => message.id)).toEqual([id("text"), id("reasoning")])
104+
expect(messages.map((message) => message.id)).toEqual([
105+
id("text"),
106+
id("signed-reasoning-with-text"),
107+
id("signed-reasoning-with-tool"),
108+
])
109+
expect(messages[1]?.content).toEqual([
110+
{ type: "reasoning", text: "", providerMetadata: { provider: { signature: "sig_2" } } },
111+
{ type: "text", text: "Visible", providerMetadata: undefined },
112+
])
113+
expect(messages[2]?.content).toEqual([
114+
{ type: "reasoning", text: "", providerMetadata: { provider: { signature: "sig_3" } } },
115+
{ type: "tool-call", id: "read", name: "read", input: { path: "README.md" } },
116+
])
83117
})
84118

85119
test("maps every top-level Session message type", () => {

0 commit comments

Comments
 (0)