Skip to content

Commit 180fd9d

Browse files
authored
fix(ai): retry Gemini MALFORMED_RESPONSE finishes (#56232)
1 parent bc5ebf0 commit 180fd9d

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

‎packages/ai/src/protocols/gemini.ts‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {
1212
} from "../route/transport/index.js"
1313
import {
1414
AIError,
15+
InvalidProviderOutputError,
1516
LLMEvent,
1617
Usage,
1718
type FinishReason,
@@ -664,6 +665,18 @@ const step = (state: ParserState, event: GeminiEvent | NextRequest) => {
664665
usage: event.usageMetadata ?? state.usage,
665666
finishReason: candidate?.finishReason ?? state.finishReason,
666667
}
668+
// Gemini sporadically ends a valid request with MALFORMED_RESPONSE; continuing or resending it recovers.
669+
if (candidate?.finishReason === "MALFORMED_RESPONSE")
670+
return Effect.fail(
671+
new AIError({
672+
reason: new InvalidProviderOutputError({
673+
route: state.route,
674+
message: `Gemini stopped with ${candidate.finishReason}`,
675+
body: ProviderShared.encodeJson(event),
676+
classification: "incomplete-stream",
677+
}),
678+
}),
679+
)
667680
if (candidate?.finishReason && mapFinishReason(candidate.finishReason, state.hasToolCalls) === "error")
668681
return Effect.fail(
669682
ProviderShared.eventError(

‎packages/ai/test/provider/gemini.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { describe, expect } from "bun:test"
22
import { Deferred, Effect, Fiber } from "effect"
33
import * as TestClock from "effect/testing/TestClock"
4-
import { LLM, AIError, LLMEvent, LLMRequest, Message, ToolCallPart, ToolDefinition, Usage, Media } from "../../src/index.js"
4+
import { LLM, AIError, LLMEvent, LLMRequest, Message, ToolCallPart, ToolDefinition, Usage, Media, isRetryable } from "../../src/index.js"
55
import { Auth, LLMClient } from "../../src/route.js"
66
import { compileRequest } from "../../src/route/client.js"
77
import * as Gemini from "../../src/protocols/gemini.js"
@@ -1709,6 +1709,7 @@ describe("Gemini route", () => {
17091709
reason: { _tag: "InvalidProviderOutput", body: JSON.stringify(event), http: { status: 200 } },
17101710
message: `Gemini stopped with ${raw}`,
17111711
})
1712+
expect(isRetryable(error)).toBe(raw === "MALFORMED_RESPONSE")
17121713
}
17131714
}),
17141715
)

0 commit comments

Comments
 (0)