Skip to content

Commit 10c567f

Browse files
committed
build(cli-rs): pin OpenTUI ff703d174
Brings borrowed Markdown reads (#2005), one keymap view per key (#2008), allocation-free Markdown lines and code blocks (#2006), exact layout for culled ScrollBox content (#2003), zeroed hidden Yoga nodes (#2009), ordered tree-sitter edits (#2002), syntax::prewarm (#2007) and notification text kept inside its OSC (#1998). The header hash changes to 0x3afe582f1647625d, so native artifacts must be rebuilt. No client code changes. #817's super+backspace binding reaches the prompt (OT817), and #1998 changes OSC 9 for text that starts with a digit and for ConEmu (OT1998).
1 parent 377cd4f commit 10c567f

4 files changed

Lines changed: 30 additions & 3 deletions

File tree

‎packages/cli-rs/Cargo.lock‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/cli-rs/Cargo.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ opencode-util = { path = "crates/util" }
3131

3232
# OpenTUI's Rust crates (`packages/rust` of anomalyco/opentui), pinned by commit. The checkout has no native library;
3333
# see README.md.
34-
opentui = { git = "https://github.com/anomalyco/opentui", rev = "35c5dbe05b61efeec77d0324cab4d3e1b1e5ae15", features = ["static", "tokio", "tree-sitter"] }
34+
opentui = { git = "https://github.com/anomalyco/opentui", rev = "ff703d174f12c3e42fe4af71a62ccd847688151f", features = ["static", "tokio", "tree-sitter"] }
3535

3636
# Expected third-party crates, declared once so steps rarely edit manifests. A crate takes one with
3737
# `name.workspace = true` and adds features with `features = [...]`.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# OT1998: notification text stays inside its OSC
2+
3+
TypeScript: the TUI uses `@opentui/core` 0.8.4 from npm. Its native notification writer copies the text byte by
4+
byte and drops only C0, DEL and ESC. A C1 control (U+009C is ST in its UTF-8 form) passes through, and OSC 9 text
5+
that starts with a digit reads as a ConEmu subcommand (`9;4;…` is progress). ConEmu, detected by name, gets OSC 9.
6+
7+
Rust: the client pins OpenTUI `ff703d174`, which includes anomalyco/opentui#1998. C0, DEL and C1 controls become
8+
spaces, text that is not UTF-8 sends nothing, OSC 9 text that starts with a digit gets one leading space
9+
(`ESC ] 9 ; ␠2 files: …`), and ConEmu gets no OSC 9 (it shows none for it anyway). The client's `normalize_text`
10+
(`tui/src/features/attention/notify.rs`) already removes control characters and always passes a non-empty title, so
11+
OSC 99 and OSC 777 bytes are the same as TS's, and OSC 9 bytes differ only when the title starts with a digit.
12+
13+
Reason: the OpenTUI fix landed after the npm release that TS uses. The difference goes away when TS moves to an
14+
`@opentui/core` release that includes #1998.
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# OT817: `super+backspace` deletes to the start of the line in the prompt
2+
3+
TypeScript: the TUI uses `@opentui/core` 0.8.4 from npm. Its default textarea bindings have no `super+backspace`, so
4+
the key does nothing in the prompt.
5+
6+
Rust: the client pins OpenTUI `ff703d174`, which includes anomalyco/opentui#817. The managed textarea layer
7+
(`ui/src/keymap/mod.rs`) appends OpenTUI's `TEXTAREA_BINDINGS` after the configured `input.*` keys, and those now
8+
bind `super+backspace` to `input.delete.to.line.start`, as macOS editors bind Cmd+Backspace. A terminal sends the
9+
key only when it reports the super modifier (the kitty keyboard protocol with Cmd or Super passed through), so most
10+
setups see no difference.
11+
12+
Reason: the OpenTUI change landed after the npm release that TS uses. The difference goes away when TS moves to an
13+
`@opentui/core` release that includes #817.

0 commit comments

Comments
 (0)