Skip to content

Commit de11152

Browse files
committed
feat: Enhanced datasets UI functionality
Signed-off-by: ntkathole <[email protected]>
1 parent 7946018 commit de11152

30 files changed

Lines changed: 5329 additions & 208 deletions

‎protos/feast/registry/RegistryServer.proto‎

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,12 @@ service RegistryServer{
6767
rpc ListSavedDatasets (ListSavedDatasetsRequest) returns (ListSavedDatasetsResponse) {}
6868
rpc DeleteSavedDataset (DeleteSavedDatasetRequest) returns (google.protobuf.Empty) {}
6969

70+
// SavedDataset Operation RPCs
71+
rpc CreateDatasetFromRetrieval (CreateDatasetFromRetrievalRequest) returns (CreateDatasetFromRetrievalResponse) {}
72+
rpc GetDatasetData (GetDatasetDataRequest) returns (GetDatasetDataResponse) {}
73+
rpc GetDatasetJobStatus (GetDatasetJobStatusRequest) returns (GetDatasetJobStatusResponse) {}
74+
rpc ListDatasetJobs (ListDatasetJobsRequest) returns (ListDatasetJobsResponse) {}
75+
7076
// ValidationReference RPCs
7177
rpc ApplyValidationReference (ApplyValidationReferenceRequest) returns (google.protobuf.Empty) {}
7278
rpc GetValidationReference (GetValidationReferenceRequest) returns (feast.core.ValidationReference) {}
@@ -423,6 +429,71 @@ message DeleteSavedDatasetRequest {
423429
bool commit = 3;
424430
}
425431

432+
// SavedDataset Operations
433+
434+
message CreateDatasetFromRetrievalRequest {
435+
string name = 1;
436+
string project = 2;
437+
string feature_service_name = 3;
438+
repeated string features = 4;
439+
string entity_source_type = 5;
440+
string entity_source_path = 6;
441+
repeated string entity_keys = 8;
442+
string entity_values = 9;
443+
string start_date = 10;
444+
string end_date = 11;
445+
string extra_columns = 12;
446+
string storage_type = 13;
447+
string storage_path = 14;
448+
map<string, string> tags = 15;
449+
bool allow_overwrite = 16;
450+
}
451+
452+
message CreateDatasetFromRetrievalResponse {
453+
string job_id = 1;
454+
string status = 2;
455+
}
456+
457+
message GetDatasetDataRequest {
458+
string name = 1;
459+
string project = 2;
460+
int32 limit = 3;
461+
}
462+
463+
message TabularRow {
464+
repeated string values = 1;
465+
}
466+
467+
message GetDatasetDataResponse {
468+
repeated string columns = 1;
469+
repeated TabularRow rows = 2;
470+
int32 total_rows = 3;
471+
int32 sample_size = 4;
472+
}
473+
474+
message GetDatasetJobStatusRequest {
475+
string job_id = 1;
476+
}
477+
478+
message GetDatasetJobStatusResponse {
479+
string job_id = 1;
480+
string dataset_name = 2;
481+
string project = 3;
482+
string status = 4;
483+
string created_at = 5;
484+
string completed_at = 6;
485+
string error = 7;
486+
}
487+
488+
message ListDatasetJobsRequest {
489+
string project = 1;
490+
string status_filter = 2;
491+
}
492+
493+
message ListDatasetJobsResponse {
494+
repeated GetDatasetJobStatusResponse jobs = 1;
495+
}
496+
426497
// ValidationReference
427498

428499
message ApplyValidationReferenceRequest {

‎sdk/python/feast/api/registry/rest/__init__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@ def register_all_routes(app: FastAPI, grpc_handler, server=None, store=None):
3535
app.include_router(get_lineage_router(grpc_handler))
3636
app.include_router(get_permission_router(grpc_handler))
3737
app.include_router(get_project_router(grpc_handler))
38-
app.include_router(get_saved_dataset_router(grpc_handler))
3938
app.include_router(get_search_router(grpc_handler))
4039
app.include_router(get_metrics_router(grpc_handler, server))
4140
resolved_store = store or (
4241
server.store if server and hasattr(server, "store") else None
4342
)
43+
app.include_router(get_saved_dataset_router(grpc_handler))
4444
app.include_router(get_monitoring_router(grpc_handler, store=resolved_store))
4545
app.include_router(get_compute_engine_router(grpc_handler, store=resolved_store))
4646

‎sdk/python/feast/api/registry/rest/rest_registry_server.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class RestRegistryServer:
3333
def __init__(self, store: FeatureStore):
3434
self.store = store
3535
self.registry = store.registry
36-
self.grpc_handler = RegistryServer(self.registry)
36+
self.grpc_handler = RegistryServer(self.registry, store=self.store)
3737
recent_visit_logging_cfg = {}
3838
feature_server_cfg = getattr(
3939
getattr(store, "config", None), "feature_server", None

0 commit comments

Comments
 (0)