3131from fastapi import (
3232 Depends ,
3333 FastAPI ,
34+ Query ,
3435 Request ,
3536 Response ,
3637 WebSocket ,
5455)
5556from feast .feast_object import FeastObject
5657from feast .feature_server_utils import convert_response_to_dict
58+ from feast .feature_view import FeatureViewState
5759from feast .feature_view_utils import get_feature_view_from_feature_store
5860from feast .filter_models import ComparisonFilter , CompoundFilter
5961from feast .permissions .action import WRITE , AuthzedAction
@@ -94,12 +96,14 @@ class MaterializeRequest(BaseModel):
9496 feature_views : Optional [List [str ]] = None
9597 disable_event_timestamp : bool = False
9698 full_feature_names : bool = False
99+ version : Optional [str ] = None
97100
98101
99102class MaterializeIncrementalRequest (BaseModel ):
100103 end_ts : str
101104 feature_views : Optional [List [str ]] = None
102105 full_feature_names : bool = False
106+ version : Optional [str ] = None
103107
104108
105109class GetOnlineFeaturesRequest (BaseModel ):
@@ -333,6 +337,96 @@ async def load_static_artifacts(app: FastAPI, store):
333337 logger .warning (f"Failed to load static artifacts: { e } " )
334338
335339
340+ def _authorize_materialize_views (
341+ store : "feast.FeatureStore" ,
342+ feature_view_names : Optional [List [str ]],
343+ ) -> List [str ]:
344+ """Resolve + authorize feature views for materialization.
345+
346+ Returns the resolved list of FV names (all eligible FVs when
347+ feature_view_names is None).
348+ """
349+ feature_views_to_materialize = store ._get_feature_views_to_materialize (
350+ feature_view_names
351+ )
352+ for fv in feature_views_to_materialize :
353+ assert_permissions (
354+ resource = fv ,
355+ actions = [AuthzedAction .WRITE_ONLINE ],
356+ )
357+ return [fv .name for fv in feature_views_to_materialize ]
358+
359+
360+ def _check_already_materializing (
361+ store : "feast.FeatureStore" ,
362+ fv_names : List [str ],
363+ ) -> Optional [JSONResponse ]:
364+ """Return a 409 JSONResponse if any requested FV is already MATERIALIZING."""
365+ conflicting : List [str ] = []
366+ for fv_name in fv_names :
367+ try :
368+ fv = store .registry .get_feature_view (
369+ fv_name , store .project , allow_cache = False
370+ )
371+ if getattr (fv , "state" , None ) == FeatureViewState .MATERIALIZING :
372+ conflicting .append (fv_name )
373+ except Exception :
374+ pass
375+ if conflicting :
376+ return JSONResponse (
377+ status_code = 409 ,
378+ content = {
379+ "error" : (
380+ f"Cannot start async materialization — the following feature "
381+ f"views are already in MATERIALIZING state: { conflicting } . "
382+ f"Use ?force=true to override."
383+ ),
384+ "feature_views" : conflicting ,
385+ },
386+ )
387+ return None
388+
389+
390+ def _update_fv_state (
391+ store : "feast.FeatureStore" ,
392+ fv_names : List [str ],
393+ state : FeatureViewState ,
394+ ) -> None :
395+ """Set FV state in the registry for each named feature view."""
396+ for fv_name in fv_names :
397+ try :
398+ fv = store .registry .get_feature_view (
399+ fv_name , store .project , allow_cache = False
400+ )
401+ fv .state = state
402+ store .registry .apply_feature_view (fv , store .project )
403+ except Exception :
404+ logger .warning (f"Failed to set state={ state } for { fv_name } " )
405+
406+
407+ def _parse_materialize_timestamps (
408+ request : "MaterializeRequest" ,
409+ ) -> tuple :
410+ """Parse and validate start/end timestamps from a MaterializeRequest."""
411+ if request .disable_event_timestamp :
412+ now = datetime .now ()
413+ return datetime (1970 , 1 , 1 ), now
414+
415+ if not request .start_ts or not request .end_ts :
416+ raise ValueError (
417+ "start_ts and end_ts are required when disable_event_timestamp is False"
418+ )
419+ try :
420+ start_date = utils .make_tzaware (parser .parse (request .start_ts ))
421+ end_date = utils .make_tzaware (parser .parse (request .end_ts ))
422+ except (ValueError , TypeError ) as e :
423+ raise ValueError (f"Invalid timestamp format: { e } " ) from e
424+
425+ if start_date >= end_date :
426+ raise ValueError (f"start_ts ({ start_date } ) must be before end_ts ({ end_date } )" )
427+ return start_date , end_date
428+
429+
336430def get_app (
337431 store : "feast.FeatureStore" ,
338432 registry_ttl_sec : int = DEFAULT_FEATURE_SERVER_REGISTRY_TTL ,
@@ -798,36 +892,47 @@ async def chat_ui():
798892 return Response (content = content , media_type = "text/html" )
799893
800894 @app .post ("/materialize" , dependencies = [Depends (inject_user_details )])
801- async def materialize (request : MaterializeRequest ) -> None :
895+ async def materialize (
896+ request : MaterializeRequest ,
897+ async_mode : bool = Query (False , alias = "async" ),
898+ force : bool = Query (False ),
899+ ):
802900 with feast_metrics .track_request_latency ("/materialize" ):
803- if request .feature_views :
804- for feature_view in request .feature_views :
805- resource = await _get_feast_object (feature_view , True )
806- assert_permissions (
807- resource = resource ,
808- actions = [AuthzedAction .WRITE_ONLINE ],
809- )
810- else :
811- feature_views_to_materialize = store ._get_feature_views_to_materialize (
812- None
813- )
814- for fv in feature_views_to_materialize :
815- assert_permissions (
816- resource = fv ,
817- actions = [AuthzedAction .WRITE_ONLINE ],
818- )
901+ fv_names = _authorize_materialize_views (store , request .feature_views )
902+ start_date , end_date = _parse_materialize_timestamps (request )
903+
904+ if async_mode :
905+ if not force :
906+ conflict = _check_already_materializing (store , fv_names )
907+ if conflict :
908+ return conflict
909+
910+ _update_fv_state (store , fv_names , FeatureViewState .MATERIALIZING )
911+
912+ def _run_materialize ():
913+ try :
914+ store .materialize (
915+ start_date ,
916+ end_date ,
917+ fv_names ,
918+ disable_event_timestamp = request .disable_event_timestamp ,
919+ full_feature_names = request .full_feature_names ,
920+ version = request .version ,
921+ )
922+ except Exception as e :
923+ logger .error (
924+ f"Async materialization failed for { fv_names } : { e } " ,
925+ exc_info = True ,
926+ )
927+ _update_fv_state (store , fv_names , FeatureViewState .GENERATED )
819928
820- if request .disable_event_timestamp :
821- now = datetime .now ()
822- start_date = datetime (1970 , 1 , 1 )
823- end_date = now
824- else :
825- if not request .start_ts or not request .end_ts :
826- raise ValueError (
827- "start_ts and end_ts are required when disable_event_timestamp is False"
828- )
829- start_date = utils .make_tzaware (parser .parse (request .start_ts ))
830- end_date = utils .make_tzaware (parser .parse (request .end_ts ))
929+ loop = asyncio .get_running_loop ()
930+ loop .run_in_executor (None , _run_materialize )
931+
932+ return JSONResponse (
933+ status_code = 202 ,
934+ content = {"status" : "accepted" , "feature_views" : fv_names },
935+ )
831936
832937 await run_in_threadpool (
833938 store .materialize ,
@@ -839,27 +944,48 @@ async def materialize(request: MaterializeRequest) -> None:
839944 )
840945
841946 @app .post ("/materialize-incremental" , dependencies = [Depends (inject_user_details )])
842- async def materialize_incremental (request : MaterializeIncrementalRequest ) -> None :
947+ async def materialize_incremental (
948+ request : MaterializeIncrementalRequest ,
949+ async_mode : bool = Query (False , alias = "async" ),
950+ force : bool = Query (False ),
951+ ):
843952 with feast_metrics .track_request_latency ("/materialize-incremental" ):
844- if request .feature_views :
845- for feature_view in request .feature_views :
846- resource = await _get_feast_object (feature_view , True )
847- assert_permissions (
848- resource = resource ,
849- actions = [AuthzedAction .WRITE_ONLINE ],
850- )
851- else :
852- feature_views_to_materialize = store ._get_feature_views_to_materialize (
853- None
953+ fv_names = _authorize_materialize_views (store , request .feature_views )
954+ end_date = utils .make_tzaware (parser .parse (request .end_ts ))
955+
956+ if async_mode :
957+ if not force :
958+ conflict = _check_already_materializing (store , fv_names )
959+ if conflict :
960+ return conflict
961+
962+ _update_fv_state (store , fv_names , FeatureViewState .MATERIALIZING )
963+
964+ def _run_materialize_incremental ():
965+ try :
966+ store .materialize_incremental (
967+ end_date ,
968+ fv_names ,
969+ full_feature_names = request .full_feature_names ,
970+ )
971+ except Exception as e :
972+ logger .error (
973+ f"Async materialize-incremental failed for { fv_names } : { e } " ,
974+ exc_info = True ,
975+ )
976+ _update_fv_state (store , fv_names , FeatureViewState .GENERATED )
977+
978+ loop = asyncio .get_running_loop ()
979+ loop .run_in_executor (None , _run_materialize_incremental )
980+
981+ return JSONResponse (
982+ status_code = 202 ,
983+ content = {"status" : "accepted" , "feature_views" : fv_names },
854984 )
855- for fv in feature_views_to_materialize :
856- assert_permissions (
857- resource = fv ,
858- actions = [AuthzedAction .WRITE_ONLINE ],
859- )
985+
860986 await run_in_threadpool (
861987 store .materialize_incremental ,
862- utils . make_tzaware ( parser . parse ( request . end_ts )) ,
988+ end_date ,
863989 request .feature_views ,
864990 full_feature_names = request .full_feature_names ,
865991 )
0 commit comments