feat(patch): fix #828, patch socket.io client#994
Conversation
JiaLiPassion
force-pushed
the
socketio
branch
4 times, most recently
from
85e737c to
52b738f
Compare
JiaLiPassion
force-pushed
the
socketio
branch
3 times, most recently
from
74437da to
2469bc9
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Seems to be failing CI. Will merge as soon as we can get it green. (ping me on slack) |
JiaLiPassion
force-pushed
the
socketio
branch
from
3acc43a to
6885151
Compare
JiaLiPassion
force-pushed
the
socketio
branch
from
6885151 to
b240946
Compare
3 participants
fix #828, patch socket.io-client.
I created a sample repo in here, https://github.com/JiaLiPassion/zone-socketio