This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(promise): fix #891, sometimes NativePromise will not ready, and reduce zone.js size#916
Merged
mhevery merged 1 commit intoangular:masterfrom Oct 3, 2017
Merged
Conversation
Closed
|
@JiaLiPassion just so I understand this a little better, the
can you elaborate a little more? Thanks! |
| patchMethod: () => noop, | ||
| setNativePromise: (NativePromise: any) => { | ||
| nativeMicroTaskQueuePromise = NativePromise.resolve(0); | ||
| // sometimes NativePromise lazy load it's prototype |
Collaborator
Author
There was a problem hiding this comment.
thanks, I will update the comment.
Collaborator
Author
|
@josephliccini , sure, in
So this will cause the error. |
…, and reduce zone.js size
JiaLiPassion
force-pushed
the
some-fix
branch
from
4a5dd63 to
295f884
Compare
|
Got it. Thank you!! |
mhevery
approved these changes
Oct 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #891
iterableandspread operatorwith new polyfill code and will makedist/zone.jsbigger, and we don't really have to useiterableandspread, so we use simple loop to reduce thezone.jssize.