Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(patch): Worker should patch onProperties#915

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:worker
Sep 27, 2017
Merged

fix(patch): Worker should patch onProperties#915
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:worker

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

@JiaLiPassion JiaLiPassion commented Sep 27, 2017

fix angular/angular#19334
Worker onProperties (onerror, onmessage) should also be patched.

@JiaLiPassion JiaLiPassion mentioned this pull request Sep 27, 2017
Closed
@mhevery mhevery merged commit 418a583 into angular:master Sep 27, 2017
@bvdmitri
Copy link
Copy Markdown

bvdmitri commented Jan 25, 2018

Safari 11.0.3 Worker has no prototype

> window['Worker']
< function WrappedWorker() {
    [native code]
}
> window['Worker'].prototype
< undefined

TypeError will be raised when getOwnPropertyDescriptor will be called with 'undefined' prototype.

@bvdmitri bvdmitri mentioned this pull request Jan 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Web Worker => Behaviorsubject => Subscribe = Not updated on the component view

4 participants

@JiaLiPassion @bvdmitri @mhevery @googlebot