Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(event): fix #883, fix RTCPeerConnection Safari event not triggered issue.#905

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:issue-883
Sep 17, 2017
Merged

fix(event): fix #883, fix RTCPeerConnection Safari event not triggered issue.#905
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:issue-883

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

@JiaLiPassion JiaLiPassion commented Sep 16, 2017

fix #883.

in safari, when trigger RTCPeerConnection event handler this context is not the same with the event target when addEventListener.

<html>
  <head>
    <!--<script src="https://cdnjs.cloudflare.com/ajax/libs/zone.js/0.8.16/zone.js"></script>-->
    <script>
      window.onload = function () {
          console.log('Create RTCPeerConnection')
          const pc = new RTCPeerConnection()

          console.log('Add "track" event listener')
          let event
          pc.addEventListener('track', function(_event) {
            console.log('this === pc', this === pc);
            console.log('track event', _event);
            event = _event
          });
          /*pc.ontrack = function(_event) {
            console.log('this === pc', this === pc);
            console.log('track event', _event);
            event = _event
          };*/

          console.log('Dispatch "track" event')
          pc.dispatchEvent(new Event('track'))

          if (event) {
            console.log('Success!')
          } else {
            console.error('Failure!')
       }
      }
    </script>
  </head>
</html>

in above case, this === pc will be false.

So in this PR, we allow user to load an additional js webapis-rtc-peer-connection.js to let zone.js patch RTCPeerConnection without using the globalCallback.

to make this PR available, please load the js as following order.

 <script src="node_modules/zone.js/dist/zone.js"></script>
 <script src="node_modules/zone.js/dist/webapis-rtc-peer-connection.js"></script>

@mhevery mhevery merged commit 6f74efb into angular:master Sep 17, 2017
@benbro benbro mentioned this pull request Oct 3, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Zone.js 0.8.13+ breaks addEventListener in Safari 11.0, 11.1

4 participants

@JiaLiPassion @benbro @mhevery @googlebot