Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(event): EventTarget of SourceBuffer in samsung tv will have null context#904

Merged
mhevery merged 3 commits intoangular:masterfrom
JiaLiPassion:samsung-tv-test
Sep 17, 2017
Merged

fix(event): EventTarget of SourceBuffer in samsung tv will have null context#904
mhevery merged 3 commits intoangular:masterfrom
JiaLiPassion:samsung-tv-test

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

@JiaLiPassion JiaLiPassion commented Sep 16, 2017

in samsung tv, the SourceBuffer.addEventListener will pass a null this in event handler.
we should handle this case by checking if this is null, we should use event.target.

@googlebot
Copy link
Copy Markdown

googlebot commented Sep 16, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link
Copy Markdown

googlebot commented Sep 16, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@mhevery mhevery merged commit 8718e07 into angular:master Sep 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JiaLiPassion @googlebot @mhevery