This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(patch): fix #886, #885, patchOnProperties getter should return original listener.#887
Merged
mhevery merged 1 commit intoangular:masterfrom Sep 6, 2017
Merged
Conversation
7dc5c1b to
7d95903
Compare
soyuka
approved these changes
Aug 29, 2017
|
Any ETA on this ? We currently have to force 0.8.16 in our project (17 is breaking) |
matt-filion
approved these changes
Sep 3, 2017
matt-filion
left a comment
There was a problem hiding this comment.
I'm not a regular contributor here but these changes seem fairly safe and are paired with a valid test case.
AnthonySaldana
approved these changes
Sep 6, 2017
mhevery
approved these changes
Sep 6, 2017
tidusjar
pushed a commit
to Ombi-app/Ombi
that referenced
this pull request
Sep 18, 2017
* Latest practices * Lock zone.js to 0.8.16 (for now, see angular/zone.js#887 ) * Use es6-compatible minifier * Attempt to fix pull req appveyor builds * Attempt build fix again * Remove cake gulp publish task - not needed anymore * Use bootswatch and remove unused bootstrap dependency * Add bootstrap * Fix things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #886.
fix #885.
fix angular/angular-cli#7502.
patchOnProperties getter should return original listener.
the issue can be described as following code.
when try to get
onProperty listenerwith such asconst listener = req.onreadystatechange, should not returnwrapFnbut the real listener.