This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(rxjs): asap should runGuarded to let error inZone#884
Merged
mhevery merged 2 commits intoangular:masterfrom Aug 23, 2017
Merged
fix(rxjs): asap should runGuarded to let error inZone#884mhevery merged 2 commits intoangular:masterfrom
mhevery merged 2 commits intoangular:masterfrom
Conversation
Contributor
|
@JiaLiPassion Can you look into why the build is red? |
Collaborator
Author
|
@mhevery , sure , I will check it. It seems |
mhevery
approved these changes
Aug 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix angular/angular#14316.
the case like this will reproduce the error, error will not in constructor zone if error throws with asap.
we should use
zone.runGuardedin patched Immediate.