This repository was archived by the owner on Feb 26, 2024. It is now read-only.
feat(onProperty): fix #875, can disable patch specified onProperties#877
Merged
mhevery merged 6 commits intoangular:masterfrom Aug 23, 2017
Merged
feat(onProperty): fix #875, can disable patch specified onProperties#877mhevery merged 6 commits intoangular:masterfrom
mhevery merged 6 commits intoangular:masterfrom
Conversation
mhevery
suggested changes
Aug 23, 2017
|
|
||
| const supportsWebSocket = typeof WebSocket !== 'undefined'; | ||
| if (canPatchViaPropertyDescriptor()) { | ||
| const ignoreProperties: IgnoreProperty[] = _global.__Zone_ignore_on_properties; |
Contributor
There was a problem hiding this comment.
could we turn this into our own module so that it is consistent with the rest of the system?
Collaborator
Author
There was a problem hiding this comment.
@mhevery , currently propertyDescriptorPatch is only be called from here, it is already in our module system.
Zone.__load_patch('on_property', (global: any, Zone: ZoneType, api: _ZonePrivate) => {
propertyDescriptorPatch(api, global);
propertyPatch();
registerElementPatch(global);
});and the _global is also from our own module parameter.
Contributor
There was a problem hiding this comment.
So what is the point of having this check?
Contributor
There was a problem hiding this comment.
Ohh, now I understand. ... :-)
mhevery
approved these changes
Aug 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #875.
can disable patch specified onProperties,for example,
if you want to disable
window.onmessageandHTMLElement.prototype.onclickfrom zone.js patching,you can do like this.