Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(patch): fix #859 readonly property should not be patched in patchPrototype#860

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:issue-859
Aug 4, 2017
Merged

fix(patch): fix #859 readonly property should not be patched in patchPrototype#860
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:issue-859

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

@JiaLiPassion JiaLiPassion commented Jul 30, 2017

fix #859, patchPrototype should not patch readonly property.

PropertyDescriptor

  • writable === false
  • only has getter.

will not be patched.

@JiaLiPassion JiaLiPassion changed the title fix(patch): fix #859 readonly property should not be patched fix(patch): fix #859 readonly property should not be patched in patchPrototype Jul 31, 2017
@mhevery mhevery merged commit 7fbd655 into angular:master Aug 4, 2017
@JiaLiPassion JiaLiPassion deleted the issue-859 branch August 10, 2017 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can i remove 'use strict'? typeError: Attempted to assign to readonly property

3 participants