@mhevery , I have finished adding test cases for basically all the APIs of rxjs 5.

• some API need to be patched, some don't. I have write which were patched and why above.
• current patch use import * as Rx from 'rxjs/RX', it will load everything from rxjs, it will have performance impact, I am not sure angular treeshaking will handle this and only bundle the used operators?
• another issue is , if user import Observable in this way import {Observable} from 'rxjs/Observable', the Observable is still non patched, if angular use webpack, we may cheat webpack to load patched Observable.

Please review.

@benlesh could you have a look?

current patch use import * as Rx from 'rxjs/RX', it will load everything from rxjs, it will have performance impact, I am not sure angular treeshaking will handle this and only bundle the used operators?

This is an issue as we are moving in the direction of individual tree shaking.

One thing which is not clear to me is why do we need to batch the scheduler? Could you give me an example where non patched scheduler will do the wrong thing?

@mhevery , about the Rx.Scheduler.asap, the following case will not work without patch.

   let func;
   constructorZone.run(() => {   
       func = function(arg0: any, callback: Function) {
           expect(Zone.current.name).toEqual(constructorZone.name);
           callback(arg0);
         };
         boundFunc = Rx.Observable.bindCallback(func, null, Rx.Scheduler.asap);
         observable = boundFunc('test');
   });
       
   observable.subscribe(...)

Because Rx.Scheduler.asap not using setImmediate but window.addEventListener('message', handler) + window.postMessage, and the handler is a global one which is initialized when bootup, so it will always be <root> zone.

@mhevery , I have updated the code and the umd build.

now rxjs patch will only import several necessary libraries which are listed in the bottom of this comment.

Please review.

What have been patched.

Below is the summarize of what have been patched.

1. Patch Observable to make sure everything created when constructing Observable will run in constructor zone.

• patch Observable.prototype._subscribe setter for new Observable(_subscribe) case.

   const observable: any = constructorZone.run(() => new Rx.Observable((_subscriber: any) => {
      expect(Zone.current.name).toEqual(constructorZone.name);
    }));

• patch Observable.create for Observable.create(_subscribe) case.

  let observable: any = constructorZone.run(() => Rx.Observable.create((subscriber: any) => {
             expect(Zone.current.name).toEqual(constructorZone.name);
    }));

• patch Observable.prototype.source for Observable.lift() case to handle all operators

  Observable.of(1,2).map(item => {
         expect(Zone.current.name).toEqual(constructorZone.name);
   });

• patch Observable.subscribe to handle tearDownLogic case

  const observable: any = constructorZone.run(() => new Rx.Observable((_subscriber: any) => {
      return () => {
        expect(Zone.current.name).toEqual(constructorZone.name);
      };
    }));

2. patch Subscriber and Subscription prototype's next/error/complete/unsubscribe.

3. Some function which was passed when constructing Observable and were executed when subscribe observable should also be patched to make sure they are run in constructor zone not subscribe zone.

• defer
• bindCallback
• bindNodeCallback
• forkJoin
• fromEventPattern
• multicast

4. patch Immediate of Rx.Scheduler.asap, Rx.Scheduler.asap use Rx.Scheduler.Immediate which not using setImmediate if window.postMessage is available. And rxjs will register a global handler for window.on('message') which make the global event handler always run in root zone, so we also need to patch Immediate.

5. For UMD build, now we build a stand alone zone-patch-rxjs.js which is an umd format library.
   and only import

import 'rxjs/add/observable/bindCallback';
import 'rxjs/add/observable/bindNodeCallback';
import 'rxjs/add/observable/defer';
import 'rxjs/add/observable/forkJoin';
import 'rxjs/add/observable/fromEventPattern';
import 'rxjs/add/operator/multicast';

import {Observable} from 'rxjs/Observable';
import {asap} from 'rxjs/scheduler/asap';
import {Subscriber} from 'rxjs/Subscriber';
import {Subscription} from 'rxjs/Subscription';

those libraries.

@mhevery , I updated again.

• basic patch use this one, this is more clearer.
  https://github.com/trxcllnt/rxjs/blob/53eddb1cca1228fe6d81aa6bec0ee0a57c8f4664/src/add/zone.ts

1. Observable.prototype._subscribe as a setter to save constructor zone.
2. Observable.prototype.source as a setter to save constructor zone in operator.
3. Observable.prototype.subscribe to run _subscribe or operator.call in constructor zone.
4. Subscription.prototype._unsubscribe as a setter to save subscription zone.
5. Subscriber.prototype.destination as a setter to save subscription.
6. Subscriber.next/error/complete to run next/error/complete in subscription zone.
7. Subscription.prototype.unsubscribe to run unsubscribe in constructor zone.

• and add Observable.defer/fromEventPattern/bindCallback/bindNodeCallback/multicast and Immediate patch.

• update import, add

import {rxSubscriber} from 'rxjs/symbol/rxSubscriber';

the reason is we need this symbol to implement toSubscribe ourselves, the toSubscribe method
is not exported in Rx.js umd module.

please review.

@mhevery , I have updated the source to remove unnecessary karma rxjs loader code , please review.

##Updated##

sorry, I did not use zone-patch-rxjs.js in karma dist test, I will modify it.