This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(event): fix #836, handle event callback call removeEventListener case#839
Merged
mhevery merged 1 commit intoangular:masterfrom Jul 14, 2017
Merged
fix(event): fix #836, handle event callback call removeEventListener case#839mhevery merged 1 commit intoangular:masterfrom
mhevery merged 1 commit intoangular:masterfrom
Conversation
mhevery
approved these changes
Jul 14, 2017
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #836.
in
listener1, the listener will remove itself. so in the current implementation,listener2will not be invoked because tasks.length was reduced.listener1, it will not remove itself, but remove otherlistenersuch as listener2.