Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

feat(patch): fix #758, patch cordova.exec success/error with zone.wrap#789

Merged
mhevery merged 2 commits intoangular:masterfrom
JiaLiPassion:cordova
Jun 3, 2017
Merged

feat(patch): fix #758, patch cordova.exec success/error with zone.wrap#789
mhevery merged 2 commits intoangular:masterfrom
JiaLiPassion:cordova

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

  1. patch cordova.exec success/error callback with Zone.wrap, and cordova.exec may not be async so I didn't patch it as a macroTask.
  2. merge fake polyfill (custom_error, fake_cordova) into a single test_fake_polyfill file.

@JiaLiPassion JiaLiPassion force-pushed the cordova branch 2 times, most recently from 7820c7f to dbadaf1 Compare May 21, 2017 02:07
Copy link
Copy Markdown
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are accidentally including the dist folder in this PR. Please update

@JiaLiPassion
Copy link
Copy Markdown
Collaborator Author

@mhevery, sorry, I will update it now.

@JiaLiPassion
Copy link
Copy Markdown
Collaborator Author

@mhevery , I have update the commit ,please review.

@mhevery mhevery merged commit 857929d into angular:master Jun 3, 2017
@JiaLiPassion JiaLiPassion deleted the cordova branch July 13, 2017 04:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants