This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(timer): fix #437, #744, fix nativescript timer and nodejs 0.10.x timer issue#772
Merged
mhevery merged 1 commit intoangular:masterfrom May 3, 2017
Merged
fix(timer): fix #437, #744, fix nativescript timer and nodejs 0.10.x timer issue#772mhevery merged 1 commit intoangular:masterfrom
mhevery merged 1 commit intoangular:masterfrom
Conversation
Collaborator
JiaLiPassion
commented
May 3, 2017
JiaLiPassion
commented
- fix zone.js issue with NativeScript #437, native script load timer module failed issue, if failed to load timer, just patch global.setTimeout
- fix fix double patched timers in older node versions #744, in nodejs 0.10.x, global.setTimeout use timers.setTimeout but not equal, we should avoid to double patch the timer. We should check if global.setTimeout use timers.setTimeout but not equal, we only set zone_symbol for consistency and then don't patch it at all in nodejs 0.10.x or other similar situation.
…e, fix nodejs v0.10.x timer issue
mhevery
approved these changes
May 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.