Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(patch): fix #719, window onproperty callback this is undefined#723

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:prop
Apr 10, 2017
Merged

fix(patch): fix #719, window onproperty callback this is undefined#723
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:prop

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

fix #719
In some browser, some of windows.onproperty, such as

  window.onerror = function() {
    // this is undefined.
  }

this is undefined, so when zone.js patch such property, should check if this is undefined and this is global , then use global insteadof this.

@mhevery mhevery merged commit 9f4db3c into angular:master Apr 10, 2017
mhevery added a commit that referenced this pull request Apr 10, 2017
@JiaLiPassion JiaLiPassion deleted the prop branch May 6, 2017 04:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PhantomJS 2.5 and zone.js 0.8.5: TypeError: undefined is not an object

3 participants