This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(zone): keep argument[0] refs around.#70
Merged
btford merged 1 commit intoangular:masterfrom Apr 8, 2015
Merged
Conversation
Without this fix, zone.js creates infinite loops when running in non-strict mode. Closes: angular#57
Contributor
Author
|
@btford this issue is pretty tricky to test. Do you think separate non-strict run of all tests would be useful? Also looks like there are broken tests at head. |
Contributor
Yes, I think so. |
Contributor
|
I'm going to merge this and cut a release so that others are unblocked, but we should run tests in non-strict as well. |
Contributor
|
Landed as 48573ff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, zone.js creates infinite loops when running in
non-strict mode.
Closes: #57