This repository was archived by the owner on Feb 26, 2024. It is now read-only.
feat(error): an idea for simple stack#693
Merged
mhevery merged 2 commits intoangular:masterfrom Apr 10, 2017
Merged
Conversation
mhevery
suggested changes
Mar 22, 2017
Contributor
mhevery
left a comment
mhevery
left a comment
There was a problem hiding this comment.
This looks great. I will have to do some perf testing before I merge it in. (Can you take care of the minor comments?)
| // Cause the error to extract the stack frames. | ||
| detectZone.runTask(detectZone.scheduleMacroTask('detect', detectRunFn, null, () => null, null)); | ||
| }); | ||
| Error.stackTraceLimit = 15; |
Contributor
There was a problem hiding this comment.
we should store and restore, rather than reset to 15
Collaborator
Author
There was a problem hiding this comment.
Sure, will do.
| const fakeTransitionTo = | ||
| (toState: TaskState, fromState1: TaskState, fromState2: TaskState) => {}; | ||
| childDetectZone.scheduleEventTask( | ||
| 'detect', |
Contributor
There was a problem hiding this comment.
to keep the size down, can we reuse existing string such as blacklistedStackFramesSymbol?
Collaborator
Author
There was a problem hiding this comment.
sure, I will modify this one.
JiaLiPassion
force-pushed
the
newerror
branch
2 times, most recently
from
65e8f5d to
aec8cff
Compare
mhevery
approved these changes
Apr 10, 2017
mhevery
pushed a commit
that referenced
this pull request
Apr 10, 2017
* feat(error): an idea for simple stack * merge detectZone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An idea to only throw one error to detect most zone stack trace frames.