Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(toString): fix #666, Zone patched method toString should like non patched#686

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:native
Mar 22, 2017
Merged

fix(toString): fix #666, Zone patched method toString should like non patched#686
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:native

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

@JiaLiPassion JiaLiPassion commented Mar 18, 2017

fix #666
after zone.js patch, function toString will look like

function addEventListener(){return f(this, arguments)}

or other patched function.

in this PR, we use the before patched delegate to output toString.
so function toString will look like

function() {[native code]}

and will pass lodash isNative test.

@JiaLiPassion JiaLiPassion force-pushed the native branch 2 times, most recently from a7b0146 to c1a2175 Compare March 19, 2017 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overriding native function can lead to unwanted side effect

3 participants