This repository was archived by the owner on Feb 26, 2024. It is now read-only.
feat(bluebird): patch bluebird promise and treat it as microtask#655
Merged
mhevery merged 1 commit intoangular:masterfrom Mar 7, 2017
Merged
feat(bluebird): patch bluebird promise and treat it as microtask#655mhevery merged 1 commit intoangular:masterfrom
mhevery merged 1 commit intoangular:masterfrom
Conversation
JiaLiPassion
force-pushed
the
bluebird
branch
3 times, most recently
from
ad37464 to
3bd9daa
Compare
mhevery
force-pushed
the
master
branch
12 times, most recently
from
b55b4ad to
f3b8885
Compare
mhevery
approved these changes
Mar 7, 2017
| @@ -0,0 +1 @@ | |||
| !function(e,o){"object"==typeof exports&&"undefined"!=typeof module?o():"function"==typeof define&&define.amd?define(o):o()}(this,function(){"use strict";!function(e){var o=Zone.__symbol__;Zone[o("bluebird")]=function(e){e.setScheduler(function(e){Zone.current.scheduleMicroTask("bluebird",e)})}}("object"==typeof window&&window||"object"==typeof self&&self||global)}); No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Don't include dist folder when you create a PR. I will update the dist folder during the release.
Collaborator
Author
There was a problem hiding this comment.
OK, got it, I will remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #455.
patch bluebird promise in zone and treat it as microTask,
add testcases for all bluebird APIs.
-usage, node
We can simplify those steps to automatically patch Bluebird Promise, if global.Promise is Bluebird, but Bluebird maybe used just as a library (such as by sequelize), so I think patch it explicitly will be much safer.