This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(patch): fix #618, use zoneSymbol as property name to avoid name conflict#645
Merged
mhevery merged 1 commit intoangular:masterfrom Mar 7, 2017
Merged
Conversation
JiaLiPassion
force-pushed
the
sharepointnew
branch
2 times, most recently
from
c9a04c2 to
faf7cef
Compare
… name conflict
JiaLiPassion
force-pushed
the
sharepointnew
branch
from
faf7cef to
228e1e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in issue #618, sharepoint's code will create property on HTMLSpanElement like this
and in zone.js
https://github.com/angular/zone.js/blob/master/lib/common/utils.ts#L77
the inner property name is also startsWith '_'
So this will cause a lot of problems.
So we just use zoneSymbol to wrap the prop name.