This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(task): eventTask/Periodical task should not be reset after being cancelled when running#642
Merged
mhevery merged 1 commit intoangular:masterfrom Mar 7, 2017
Merged
Conversation
8d27605 to
8620cec
Compare
…eset after cancel in running state
8620cec to
cfb5c69
Compare
This was referenced Feb 24, 2017
|
Can this be released anytime soon? Because it breaks Angular applications in most of the cases. |
|
Thank you so much @mhevery my Angular 2 app is stable again after this update :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the issue can be described as the following cases.
When task is cancelled in task's callback(running state), the runTask logic here https://github.com/angular/zone.js/blob/master/lib/zone.ts#L757 will reset the task's state to scheduled, so it will cause issues such as #638, updateTaskCount cause null error, because the task is cancelled but still in scheduled state.