Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(timers): cleanup task reference when exception#637

Merged
mhevery merged 1 commit intoangular:masterfrom
bsergei:master
Mar 7, 2017
Merged

fix(timers): cleanup task reference when exception#637
mhevery merged 1 commit intoangular:masterfrom
bsergei:master

Conversation

@bsergei
Copy link
Copy Markdown
Contributor

@bsergei bsergei commented Feb 14, 2017

Reference to task is not removed when timer's handler was faulty with exception. This can lead to memory leak.

@googlebot
Copy link
Copy Markdown

googlebot commented Feb 14, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link
Copy Markdown

googlebot commented Feb 14, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@bsergei
Copy link
Copy Markdown
Contributor Author

bsergei commented Feb 14, 2017

I signed it!

@googlebot
Copy link
Copy Markdown

googlebot commented Feb 14, 2017

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Copy Markdown

googlebot commented Feb 14, 2017

CLAs look good, thanks!

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Feb 17, 2017

Could we have a test for this?

@mhevery mhevery force-pushed the master branch 12 times, most recently from b55b4ad to f3b8885 Compare March 7, 2017 18:05
@mhevery mhevery merged commit 2594940 into angular:master Mar 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bsergei @googlebot @mhevery