Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

patch crypto as macroTask and add test cases for crypto, remove http patch#612

Merged
mhevery merged 2 commits intoangular:masterfrom
JiaLiPassion:node
Jan 23, 2017
Merged

patch crypto as macroTask and add test cases for crypto, remove http patch#612
mhevery merged 2 commits intoangular:masterfrom
JiaLiPassion:node

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

@JiaLiPassion JiaLiPassion commented Jan 22, 2017

  1. Use patchMacroTask generic method to patch crypto randomBytes and pbkdf2 method.
    and add test cases.
  2. remove patch to http.ClientRequest, because in http.request(options, [cb]), the callback method is just a once listener which was added to req, so it has already been patched with EventEmitter patch.

@JiaLiPassion JiaLiPassion changed the title patch crypto as macroTask and add test cases for crypto patch crypto as macroTask and add test cases for crypto, remove http patch Jan 23, 2017
@mhevery mhevery merged commit c238aa4 into angular:master Jan 23, 2017
mhevery pushed a commit that referenced this pull request Jan 23, 2017
…emove http patch (#612)

* patch crypto as macroTask and add test cases for crypto

* remove http patch, because it has been patched by EventEmitter
@JiaLiPassion JiaLiPassion deleted the node branch February 14, 2017 06:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants