Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix #607 to change catch variable name to error/err#609

Merged
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:uglifyjs
Jan 23, 2017
Merged

fix #607 to change catch variable name to error/err#609
mhevery merged 1 commit intoangular:masterfrom
JiaLiPassion:uglifyjs

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Collaborator

fix #607, sometimes uglifyjs will generate wrong code when our code like this.

try {
  doSomething();
} catch(e) {
  errorHandling();
}

after uglifyjs, sometimes the code may become

try {
  doSomething();
} catch(e) {
  e();
}

although use screwie8 option can resolve such issue, but to use another variable name other than 'e' is much safe.

@mhevery mhevery merged commit bbe5bff into angular:master Jan 23, 2017
@JiaLiPassion JiaLiPassion deleted the uglifyjs branch February 14, 2017 06:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edge: Object doesn't support property or method 'fetch'

3 participants